Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default tags to CertificateAuthority #1113

Conversation

cebernardi
Copy link
Contributor

@cebernardi cebernardi commented Feb 1, 2022

Signed-off-by: Cecilia Bernardi cbernardi@expediagroup.com

Description of your changes

This PR adds the default tags to acmpca.CertificateAuthority resource ("crossplane-kind", "crossplane-name", "crossplane-providerconfig")

Fixes #1143

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Unit Tests
  • Manual Test on a kind cluster:
    • spin up a new kind cluster (kind create cluster --name crossplane-aws)
    • install CRDs (kubectl apply -f package/crds)
    • create resource scenario:
      • create an acmpca.CertificateAuthority in the cluster (kubectl apply -f examples/acmpca/certificateauthority.yaml)
      • start crossplane-aws controller
      • verify that the tags "crossplane-kind", "crossplane-name", "crossplane-providerconfig" are added as expected
    • modify resource scenario:
      • delete tags from the resource: kubectl patch certificateauthorities.acmpca.aws.crossplane.io/example --type=json -p='[{"op": "remove", "path":"/spec/forProvider/tags"}]'
      • verify that the tags "crossplane-kind", "crossplane-name", "crossplane-providerconfig" are re-added as expected
    • start controller scenario:
      • stop provider-aws controller
      • reset the acmpca.CertificateAuthority (kubectl apply -f examples/acmpca/certificateauthority.yaml)
      • start crossplane-aws controller
      • verify that the tags "crossplane-kind", "crossplane-name", "crossplane-providerconfig" are added as expected

Signed-off-by: Cecilia Bernardi <cbernardi@expediagroup.com>
@cebernardi cebernardi changed the title added default tags to CertificateAuthority Added default tags to CertificateAuthority Feb 7, 2022
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementation - tested & it is working

@haarchri haarchri merged commit 75e7227 into crossplane-contrib:master Feb 20, 2022
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…d-gen

[docdb]: Add autoGeneratePassword capability to Cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CertificateAuthority misses default crossplane tags
2 participants