feat(ack): bump ack & aws-go-sdk-v1 to 1.42.0 #1122

haarchri · 2022-02-06T13:13:11Z

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

bump ack to latest commit since go-sdk-v1 1.42.0
bump go-sdk-v1 to 1.42.0
added all "new" resources to ignore resources in generator-config.yaml
skip ec2 vpcendpoints clientToken (Create&CreateOutput) fields and added preCreate
cleanup kafka server ZookeeperConnectString and ZookeeperConnectStringTLS because these fields should only available via connectionSecret not as input fields
2 new required fields for resource mq broker publiclyAccessible and autoMinorVersionUpgrade
changed examples for 'mq' to fits same region then our other examples
changed examples for docdb to fits Ref/Selector
changed examples for cloudfront distribution originAccessIDentity to originAccessIdentity
changed examples for rds to fits same region then our other examples
rds instance fixing the constant configuring-enhanced-monitoring state changes
fixed missing resolvers/selectors for ec2 vpcpeeringconnection vpcPeerIDRef/Selector
changed example for secretsmanager secret to have stringSecretRef for testing
fixed missing resolvers/selector for apigatewayv2 vpc-link in v1beta1
fixed condition for deletion / observed for ec2 launchtemplateversion failed to describe LaunchTemplateVersion: InvalidLaunchTemplateName.NotFoundException: The specified launch template, with template name test-crossplane-obj, does not exist.

changed required fields:

docdb.aws.crossplane.io_dbclusters.yaml

spec.versions.v1alpha1.schema.openAPIV3Schema.properties.spec.properties.forProvider.required
  - one list entry removed:
    - masterUsername

mq.aws.crossplane.io_brokers.yaml - check for more informations - its safe for folks installations ;) feat(ack): bump ack & aws-go-sdk-v1 to 1.42.0 #1122 (comment)

spec.versions.v1alpha1.schema.openAPIV3Schema.properties.spec.properties.forProvider.required
  + six list entries added:
    - autoMinorVersionUpgrade
    - deploymentMode
    - engineType
    - engineVersion
    - hostInstanceType
    - publiclyAccessible

tested with master and this PR - the migration is save

Fixes #853
Fixes #918
Fixes #980

I have:

Read and followed Crossplane's contribution process.
Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Done
efs, kms, athena, glue, neptune, transfer, lambda, mq, kinesis, cloudfront, iot, docdb, rds, sfn, cloudwatchlogs, elbv2, dynamodb, ec2, route53resolver, servicediscovery, elasticache, secretsmanager, apigatewayv2, eks, ram

kubectl apply -f examples/ec2/vpc.yaml   
kubectl apply -f examples/ec2/subnet.yaml
kubectl apply -f examples/ec2/securitygroup.yaml
kubectl apply -f examples/iam/role.yaml
kubectl apply -f examples/iam/policy.yaml
kubectl apply -f examples/iam/rolepolicyattachment.yaml
kubectl apply -f examples/kms/key.yaml 
kubectl apply -f examples/ec2/internetgatway.yaml 
kubectl apply -f examples/ec2/routetable.yaml 

kubectl apply -f examples/lambda/function.yaml 
kubectl apply -f examples/efs
kubectl apply -f examples/athena
kubectl apply -f examples/glue
kubectl apply -f examples/neptune 
kubectl apply -f examples/transfer
kubectl apply -f examples/kafka
kubectl apply -f examples/mq
kubectl apply -f examples/kinesis/stream.yaml 
kubectl apply -f examples/cloudfront
kubectl apply -f examples/hot
kubectl apply -f examples/docdb
kubectl apply -f examples/rds
kubectl apply -f examples/sfn
kubectl apply -f examples/cloudwatchlogs
kubectl apply -f examples/elbv2
kubectl apply -f examples/dynamodb
kubectl apply -f examples/ec2/transitgateway.yaml
kubectl apply -f examples/ec2/transitgatewayroute.yaml
kubectl apply -f examples/ec2/transitgatewayroutetable.yaml
kubectl apply -f examples/ec2/transitgatewayvpcattachment.yaml
kubectl apply -f examples/ec2/volume.yaml
kubectl apply -f examples/ec2/launchtemplate.yaml
kubectl apply -f examples/ec2/launchtemplateversion.yaml
kubectl apply -f examples/ec2/vpcendpoint.yaml
kubectl apply -f examples/ec2/vpcendpointserviceconfiguration.yaml
kubectl apply -f examples/ec2/vpcpeeringconnection.yaml
kubectl apply -f examples/ec2/route.yaml
kubectl apply -f examples/route53resolver/resolverruleassociation/resolverruleassociation.yaml 
kubectl apply -f examples/route53resolver/resolverrule/resolvererule.yaml 
kubectl apply -f examples/route53resolver/resolverendpoint/resolverendpoint.yaml
kubectl apply -f examples/servicediscovery
kubectl apply -f examples/cache/cacheparametergroup.yaml
kubectl apply -f examples/secretsmanager
kubectl apply -f examples/apigatewayv2
kubectl apply -f examples/eks/addon.yaml
kubectl apply -f examples/ram

NAME                                                  READY   SYNCED   EXTERNAL-NAME
vpclink.apigatewayv2.aws.crossplane.io/test-vpclink   True    True     gd31jp

NAME                                                          READY   SYNCED   EXTERNAL-NAME
integration.apigatewayv2.aws.crossplane.io/test-integration   True    True     q5uvhcs

NAME                                                           READY   SYNCED   EXTERNAL-NAME
apimapping.apigatewayv2.aws.crossplane.io/test-ws-apimapping   True   True  tjz43b7  

NAME                                              READY   SYNCED   EXTERNAL-NAME
route.apigatewayv2.aws.crossplane.io/test-route   True    True     4fgmm51

NAME                                                        READY   SYNCED   EXTERNAL-NAME
authorizer.apigatewayv2.aws.crossplane.io/test-authorizer   True    True     5c8flk

NAME                                             READY   SYNCED   EXTERNAL-NAME
model.apigatewayv2.aws.crossplane.io/testmodel   True    True     y7254s

NAME                                                        READY   SYNCED   EXTERNAL-NAME
deployment.apigatewayv2.aws.crossplane.io/test-deployment   True    True     gmaze8

NAME                                                              READY   SYNCED   EXTERNAL-NAME
routeresponse.apigatewayv2.aws.crossplane.io/test-routeresponse   True    True     9b3nel

NAME                                               READY   SYNCED   EXTERNAL-NAME
api.apigatewayv2.aws.crossplane.io/test-http-api   True    True     eupscc1is2
api.apigatewayv2.aws.crossplane.io/test-ws-api     True    True     6ovf7qw40c

NAME                                                                          READY   SYNCED   EXTERNAL-NAME
integrationresponse.apigatewayv2.aws.crossplane.io/test-integrationresponse   True    True     tjz43b7

NAME                                              READY   SYNCED   EXTERNAL-NAME
stage.apigatewayv2.aws.crossplane.io/test-stage   True    True     test-stage

NAME                                                        READY   SYNCED   EXTERNAL-NAME
domainname.apigatewayv2.aws.crossplane.io/test-domainname   True   True    dev.xetu.de

NAME                                                   READY   SYNCED   EXTERNAL-NAME
workgroup.athena.aws.crossplane.io/example-workgroup   True    True     example-workgroup

NAME                                                           READY   SYNCED   EXTERNAL-NAME
cachepolicy.cloudfront.aws.crossplane.io/example-cachepolicy   True    True     491710bc-c727-4f57-a9c0-c168400be70e

NAME                                                                           READY   SYNCED   EXTERNAL-NAME
distribution.cloudfront.aws.crossplane.io/example-distribution                 True    True     E3TIMAZYGE60LD
distribution.cloudfront.aws.crossplane.io/example-distribution-custom-origin   True    True     E1DJMN5OSBE79C

NAME                                                                                         READY   SYNCED   EXTERNAL-NAME
cloudfrontoriginaccessidentity.cloudfront.aws.crossplane.io/example-origin-access-identity   True    True     E2YADW293BPRBU

NAME                                                        READY   SYNCED   EXTERNAL-NAME
loggroup.cloudwatchlogs.aws.crossplane.io/sample-loggroup   True    True     /aws/eks/sample-cluster/cluster

NAME                                                         READY   SYNCED   EXTERNAL-NAME
dbsubnetgroup.docdb.aws.crossplane.io/example-subnet-group   True    True     example-subnet-group

NAME                                                  READY   SYNCED   EXTERNAL-NAME
dbinstance.docdb.aws.crossplane.io/example-instance   True    True     example-instance

NAME                                                READY   SYNCED   EXTERNAL-NAME
dbcluster.docdb.aws.crossplane.io/example-cluster   True    True     example-cluster

NAME                                                                      READY   SYNCED   EXTERNAL-NAME
dbclusterparametergroup.docdb.aws.crossplane.io/example-parameter-group   True    True     example-parameter-group

NAME                                              READY   SYNCED   EXTERNAL-NAME
backup.dynamodb.aws.crossplane.io/sample-backup   True    True     arn:aws:dynamodb:us-east-1:436715084175:table/sample-table/backup/01645427138972-b6341387

NAME                                                  READY   SYNCED   EXTERNAL-NAME
globaltable.dynamodb.aws.crossplane.io/sample-table   True    True     sample-table

NAME                                                                     READY   SYNCED   EXTERNAL-NAME
table.dynamodb.aws.crossplane.io/sample-table                            True    True     sample-table
table.dynamodb.aws.crossplane.io/sample-table-global-secondary-indexes   True    True     sample-table-global-secondary-indexes
table.dynamodb.aws.crossplane.io/sample-table-ppr                        True    True     sample-table-ppr
table.dynamodb.aws.crossplane.io/sample-table-with-sse                   True    True     sample-table-with-sse
table.dynamodb.aws.crossplane.io/sample-table-without-sse                True    True     sample-table-without-sse

NAME                                          READY   SYNCED   ID                         VPC                     CIDR          AGE
subnet.ec2.aws.crossplane.io/sample-subnet1   True    True     subnet-0c6fc7d366145f4cd   vpc-07094b90dba0386f2   10.0.1.0/24   22h
subnet.ec2.aws.crossplane.io/sample-subnet2   True    True     subnet-03f46aa4732ffeec2   vpc-07094b90dba0386f2   10.0.2.0/24   22h

NAME                                    READY   SYNCED   ID                      CIDR          IPV6CIDR   AGE
vpc.ec2.aws.crossplane.io/sample-vpc    True    True     vpc-07094b90dba0386f2   10.0.0.0/16              22h
vpc.ec2.aws.crossplane.io/sample-vpc2   True    True     vpc-0921454e374ba9af6   10.1.0.0/16              22h

NAME                                                           READY   SYNCED   ID                      VPC                     AGE
internetgateway.ec2.aws.crossplane.io/sample-internetgateway   True    True     igw-096647bed2bb71e55   vpc-07094b90dba0386f2   15h

NAME                                                 READY   SYNCED   ID                      VPC                     AGE
routetable.ec2.aws.crossplane.io/sample-routetable   True    True     rtb-028d1d12f0f2f94ab   vpc-07094b90dba0386f2   15h

NAME                                                    READY   SYNCED   ID                     VPC                     AGE
securitygroup.ec2.aws.crossplane.io/sample-cluster-sg   True    True     sg-016f4341e27950f5c   vpc-07094b90dba0386f2   22h

NAME                                                       READY   SYNCED   EXTERNAL-NAME
launchtemplate.ec2.aws.crossplane.io/test-crossplane-obj   True    True     test-crossplane-obj

NAME                                  READY   SYNCED   EXTERNAL-NAME
route.ec2.aws.crossplane.io/example   True    True     example

NAME                                   READY   SYNCED   EXTERNAL-NAME
volume.ec2.aws.crossplane.io/example   True    True     vol-0e39041493b67a79e

NAME                                                 READY   SYNCED   EXTERNAL-NAME
vpcpeeringconnection.ec2.aws.crossplane.io/example   True    True     pcx-08e6d12fc9bae5557

NAME                                                                                READY   SYNCED   EXTERNAL-NAME
vpcendpointserviceconfiguration.ec2.aws.crossplane.io/sample-vpc-endpoint-service   True    True     vpce-svc-0a9c2326175acc8d0

NAME                                       READY   SYNCED   EXTERNAL-NAME
transitgateway.ec2.aws.crossplane.io/tgw   True    True     tgw-072f3670469830cb5

NAME                                                   READY   SYNCED   EXTERNAL-NAME
vpcendpoint.ec2.aws.crossplane.io/sample-vpcendpoint   True    True     vpce-0fa855573a9c247a3

NAME                                                            READY   SYNCED   EXTERNAL-NAME
transitgatewayroutetable.ec2.aws.crossplane.io/tgw-routetable   True    True     tgw-rtb-03404399756879d72

NAME                                                               READY   SYNCED   EXTERNAL-NAME
transitgatewayvpcattachment.ec2.aws.crossplane.io/tgw-vpc-attach   True    True     tgw-attach-0690141dbca4e6425

NAME                                                             READY   SYNCED   EXTERNAL-NAME
transitgatewayroute.ec2.aws.crossplane.io/tgw-route-blackhole    True    True     tgw-route-blackhole
transitgatewayroute.ec2.aws.crossplane.io/tgw-route-vpc-attach   True    True     tgw-route-vpc-attach

NAME                                                             READY   SYNCED   EXTERNAL-NAME
launchtemplateversion.ec2.aws.crossplane.io/test-crossplane-v3   True    True     2

NAME                                       READY   SYNCED   EXTERNAL-NAME
filesystem.efs.aws.crossplane.io/example   True    True     fs-09f7d1c71220fc595

NAME                                        READY   SYNCED   EXTERNAL-NAME
mounttarget.efs.aws.crossplane.io/example   True    True     fsmt-01b07e0c4ad0c13c1

NAME                                       READY   SYNCED   EXTERNAL-NAME
addon.eks.aws.crossplane.io/sample-addon   True    True        arn:aws:eks:us-east-1:436715084175:addon/test-cluster/coredns/28be7ce5-90c1-0bec-083e-f25b36990e5d

NAME                                                                      READY   SYNCED   EXTERNAL-NAME
cacheparametergroup.elasticache.aws.crossplane.io/cache-parameter-group   True    True     cache-parameter-group

NAME                                                 READY   SYNCED   EXTERNAL-NAME
listener.elbv2.aws.crossplane.io/test-listener       True    True     arn:aws:elasticloadbalancing:us-east-1:436715084175:listener/app/test-loadbalancer/d9c31a34fbf3e214/cecf8e40dbf7ae1d
listener.elbv2.aws.crossplane.io/test-listener-two   True    True     arn:aws:elasticloadbalancing:us-east-1:436715084175:listener/app/test-loadbalancer/d9c31a34fbf3e214/d45ce487a65b5a00

NAME                                                   READY   SYNCED   EXTERNAL-NAME
targetgroup.elbv2.aws.crossplane.io/test-targetgroup   True    True     arn:aws:elasticloadbalancing:us-east-1:436715084175:targetgroup/test-targetgroup/3d7fff6b13ac17b1

NAME                                                       READY   SYNCED   EXTERNAL-NAME
loadbalancer.elbv2.aws.crossplane.io/gatewayloadbalancer   True    True     arn:aws:elasticloadbalancing:us-east-1:436715084175:loadbalancer/gwy/gatewayloadbalancer/eeb13f3bcf13780d
loadbalancer.elbv2.aws.crossplane.io/test-loadbalancer     True    True     arn:aws:elasticloadbalancing:us-east-1:436715084175:loadbalancer/app/test-loadbalancer/d9c31a34fbf3e214

NAME                                                                      READY   SYNCED   EXTERNAL-NAME
securityconfiguration.glue.aws.crossplane.io/glue-securityconfiguration   True    True     glue-securityconfiguration

NAME                                            READY   SYNCED   EXTERNAL-NAME
database.glue.aws.crossplane.io/glue-database   True    True     glue-database

NAME                                          READY   SYNCED   EXTERNAL-NAME
crawler.glue.aws.crossplane.io/glue-crawler   True    True     glue-crawler

NAME                                                READY   SYNCED   EXTERNAL-NAME
connection.glue.aws.crossplane.io/glue-connection   True    True     glue-connection

NAME                                                     READY   SYNCED   EXTERNAL-NAME
classifier.glue.aws.crossplane.io/glue-classifier-csv    True    True     glue-classifier-csv
classifier.glue.aws.crossplane.io/glue-classifier-grok   True    True     glue-classifier-grok
classifier.glue.aws.crossplane.io/glue-classifier-json   True    True     glue-classifier-json
classifier.glue.aws.crossplane.io/glue-classifier-xml    True    True     glue-classifier-xml

NAME                                  READY   SYNCED   EXTERNAL-NAME
job.glue.aws.crossplane.io/glue-job   True    True     glue-job

NAME                                          READY   SYNCED   EXTERNAL-NAME
policy.iot.aws.crossplane.io/example-policy   True    True     example-policy

NAME                                        READY   SYNCED   EXTERNAL-NAME
thing.iot.aws.crossplane.io/example-thing   True    True     example-thing

NAME                                      READY   SYNCED   EXTERNAL-NAME
cluster.kafka.aws.crossplane.io/example   True    True     arn:aws:kafka:us-east-1:436715084175:cluster/example/48fc96e9-1bf6-489c-8286-f6af7ca60076-9

NAME                                                          READY   SYNCED   EXTERNAL-NAME
configuration.kafka.aws.crossplane.io/example-configuration   True    True     arn:aws:kafka:us-east-1:436715084175:configuration/example-configuration/46474fd8-45bf-4b51-bb52-0dd85258c301-9

NAME                                              READY   SYNCED   EXTERNAL-NAME
stream.kinesis.aws.crossplane.io/kinesis-stream   True    True     kinesis-stream

NAME                                READY   SYNCED   EXTERNAL-NAME
key.kms.aws.crossplane.io/dev-key   True    True     0872f260-17e9-499f-a8fa-9d04926ebcc0

NAME                                           READY   SYNCED   EXTERNAL-NAME
broker.mq.aws.crossplane.io/example-activemq   True    True     b-f910f180-035f-45cf-84de-010e1b8f031f
broker.mq.aws.crossplane.io/example-rabbitmq   True    True     b-7eaac7a8-57ed-48ab-a1d4-28174e61fcde

NAME                                              READY   SYNCED   EXTERNAL-NAME
user.mq.aws.crossplane.io/example-activemq-user   True    True     example-activemq-user

NAME                                                 READY   SYNCED   EXTERNAL-NAME
dbcluster.neptune.aws.crossplane.io/sample-cluster   True    True     sample-cluster

NAME                                                  READY   SYNCED   EXTERNAL-NAME
resourceshare.ram.aws.crossplane.io/example-sharing   True   True  0628f4c3-02d2-43ae-8413-ed4514fb339f

NAME                                                        READY   SYNCED   EXTERNAL-NAME
globalcluster.rds.aws.crossplane.io/example-globalcluster   True    True     example-globalcluster

NAME                                                              READY   SYNCED   EXTERNAL-NAME
dbparametergroup.rds.aws.crossplane.io/example-dbparametergroup   True    True     example-dbparametergroup

NAME                                                           READY   SYNCED   EXTERNAL-NAME
dbcluster.rds.aws.crossplane.io/example-aurora-mysql-cluster   True    True     example-aurora-mysql-cluster

NAME                                                             READY   SYNCED   EXTERNAL-NAME
dbinstance.rds.aws.crossplane.io/example-aurora-mysql-instance   True    True    example-aurora-mysql-instance
dbinstance.rds.aws.crossplane.io/example-dbinstance              True    True     example-dbinstance

NAME                                                                          READY   SYNCED   EXTERNAL-NAME
dbclusterparametergroup.rds.aws.crossplane.io/example-clusterparametergroup   True    True     example-clusterparametergroup

NAME                                                                 READY   SYNCED   EXTERNAL-NAME
resolverendpoint.route53resolver.aws.crossplane.io/sample-resolver   True    True     rslvr-out-2ae5a52227794a5eb

NAME                                                                  READY   SYNCED   EXTERNAL-NAME
resolverrule.route53resolver.aws.crossplane.io/sample-resolver-rule   True    True     rslvr-rr-723a125320164cf8a

NAME                                                       READY   SYNCED   EXTERNAL-NAME
secret.secretsmanager.aws.crossplane.io/example-secret-3   True    True     example-secret-3

NAME                                                                                 READY   SYNCED   EXTERNAL-NAME
privatednsnamespace.servicediscovery.aws.crossplane.io/example-privatednsnamespace   True    True     ns-5nl6jfksp5tse57o

NAME                                                                     READY   SYNCED   EXTERNAL-NAME
httpnamespace.servicediscovery.aws.crossplane.io/example-httpnamespace   True    True     ns-hre4xgrgemrancwy

NAME                                                                           READY   SYNCED   EXTERNAL-NAME
publicdnsnamespace.servicediscovery.aws.crossplane.io/publicdnsnamespace.com   True    True     ns-esxlfr3ymmljnzvm

NAME                                                     READY   SYNCED   EXTERNAL-NAME
statemachine.sfn.aws.crossplane.io/sample-statemachine   True    True     arn:aws:states:us-east-1:436715084175:stateMachine:sample-statemachine

NAME                                             READY   SYNCED   EXTERNAL-NAME
activity.sfn.aws.crossplane.io/sample-activity   True    True     arn:aws:states:us-east-1:436715084175:activity:sample-activity

NAME                                        READY   SYNCED   EXTERNAL-NAME
server.transfer.aws.crossplane.io/example   True    True     s-deb1edf243e545e5a

NAME                                       ARN                                              READY   SYNCED   AGE
policy.iam.aws.crossplane.io/glue-policy   arn:aws:iam::436715084175:policy/glue-policy     True    True     22h
policy.iam.aws.crossplane.io/somepolicy    arn:aws:iam::436715084175:policy/external-name   True    True     22h

NAME                                      READY   SYNCED   AGE
role.iam.aws.crossplane.io/glue-role      True    True     22h
role.iam.aws.crossplane.io/somenoderole   True    True     22h
role.iam.aws.crossplane.io/somerole       True    True     22h

NAME                                                                                 READY   SYNCED   ROLENAME       POLICYARN                                                    AGE
rolepolicyattachment.iam.aws.crossplane.io/glue-rolepolicyattachment                 True    True     glue-role      arn:aws:iam::436715084175:policy/glue-policy                 22h
rolepolicyattachment.iam.aws.crossplane.io/sample-noderolemanagedpolicyattachment1   True    True     somenoderole   arn:aws:iam::aws:policy/AmazonEKSWorkerNodePolicy            22h
rolepolicyattachment.iam.aws.crossplane.io/sample-noderolemanagedpolicyattachment2   True    True     somenoderole   arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly   22h
rolepolicyattachment.iam.aws.crossplane.io/sample-noderolemanagedpolicyattachment3   True    True     somenoderole   arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy                 22h
rolepolicyattachment.iam.aws.crossplane.io/sample-rolemanagedpolicyattachment        True    True     somerole       arn:aws:iam::aws:policy/AmazonEKSClusterPolicy               22h
rolepolicyattachment.iam.aws.crossplane.io/sample-rolepolicyattachment               True    True     somerole       arn:aws:iam::436715084175:policy/external-name               22h
rolepolicyattachment.iam.aws.crossplane.io/sample-s3-replication-policy              True    True     somerole       arn:aws:iam::aws:policy/AmazonS3FullAccess                   22h

and deleted all resources afterwards

haarchri · 2022-02-06T16:08:07Z

@muvaf anything i need to check more ? i will start testing the resources and will give feedback here

package/crds/ec2.aws.crossplane.io_vpcendpoints.yaml

package/crds/kafka.aws.crossplane.io_clusters.yaml

muvaf · 2022-02-08T22:30:01Z

@haarchri can we save this to after the release on Feb 9th?

haarchri · 2022-02-09T07:48:49Z

@muvaf we can do this for 0.25 release

jbw976 · 2022-02-19T02:29:40Z

@muvaf how do you feel about getting this in now that v0.24 has shipped? 😊 🤔

haarchri · 2022-02-19T06:12:59Z

I will do today a check if our examples will work think then we can go

haarchri · 2022-02-20T17:56:29Z

added current state of testing

haarchri · 2022-02-20T22:05:46Z

added next testing and updated examples for docdb, cloudfront, mq, rds

Signed-off-by: Yury Tsarev <yury@upbound.io>

goober · 2022-02-21T08:51:22Z

First of all, great work @haarchri ! ~~Just for curiosity, what is the main reason that you have chosen to upgrade to 1.42.0 and not the latest patch release of the 1.42.x version?~~

I can answer my own question.. provider-aws needs to follow the same version as the code-generator-project is using.

haarchri · 2022-02-21T09:16:23Z

@goober yes because of the code-generator version ;)

haarchri · 2022-02-21T14:16:46Z

@muvaf @jbw976 done with testing - found a few problems in examples and ref/selectors fixed that to check if the sdk bump is really working - feel free to add review ;)

muvaf

Thank you for taking care of this @haarchri ! I tried to sweep through the CRDs for breaking changes but there might be some that I couldn't catch. I think that's the most important part when we do an SDK bump along with the tests that you've done.

package/crds/mq.aws.crossplane.io_brokers.yaml

pkg/controller/servicediscovery/httpnamespace/setup.go

pkg/controller/transfer/server/setup.go

muvaf

A few small nitpick comments but looking great. Thanks @haarchri !

apis/secretsmanager/v1alpha1/deprecated_secret.go

examples/docdb/cluster.yaml

examples/docdb/subnet-group.yaml

pkg/controller/transfer/server/setup.go

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri · 2022-03-07T11:34:05Z

e2e-tests are failing since we merged crossplane/crossplane#2932

using crossplane version 1.7.0-rc.0.125.gfff10011

kubectl get pkgrev
NAME                                                           HEALTHY   REVISION   IMAGE          STATE    DEP-FOUND   DEP-INSTALLED   AGE
providerrevision.pkg.crossplane.io/provider-aws-provider-aws             1          provider-aws   Active                               2m40s

Events:
  Type     Reason             Age                    From                                         Message
  ----     ------             ----                   ----                                         -------
  Normal   BindClusterRole    2m10s (x3 over 2m10s)  rbac/providerrevision.pkg.crossplane.io      Bound system ClusterRole to provider ServiceAccount(s)
  Normal   ApplyClusterRoles  2m10s (x2 over 2m10s)  rbac/providerrevision.pkg.crossplane.io      Applied RBAC ClusterRoles
  Warning  ParsePackage       9s (x8 over 2m10s)     packages/providerrevision.pkg.crossplane.io  failed to get pre-cached package with pull policy Never

tested locally with crossplane 1.6.3 without issues

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri · 2022-03-07T15:53:37Z

we changed e2e tests using crossplane stable channel as of crossplane/crossplane#2944

Signed-off-by: Yury Tsarev <yury@upbound.io>

Remove the Terraform CLI from the provider package and deprecate the relevant provider command-line flags

haarchri requested a review from muvaf February 6, 2022 16:07

muvaf reviewed Feb 7, 2022

View reviewed changes

package/crds/ec2.aws.crossplane.io_vpcendpoints.yaml Outdated Show resolved Hide resolved

package/crds/kafka.aws.crossplane.io_clusters.yaml Show resolved Hide resolved

haarchri mentioned this pull request Feb 7, 2022

feat(iam): Add ServiceLinkedRole #1118

Merged

2 tasks

This was referenced Feb 9, 2022

upgrade aws-sdk-go from 1.37.4 to 1.42.0 #918

Closed

ack go-sdk-v1.42.0 ClientToken Field in VPCEndpointObservation aws-controllers-k8s/community#1172

Closed

haarchri force-pushed the feature/ack-bump-sdk-1.42.0 branch 2 times, most recently from 3ab4638 to a6b344a Compare February 15, 2022 20:57

haarchri force-pushed the feature/ack-bump-sdk-1.42.0 branch 2 times, most recently from 2d17d9f to 6ee453c Compare February 20, 2022 14:36

haarchri added the breaking-change label Feb 20, 2022

haarchri mentioned this pull request Feb 20, 2022

mq activemq user unable to create aws/aws-sdk-go#4286

Closed

3 tasks

ytsarev added a commit to ytsarev/provider-aws that referenced this pull request Feb 20, 2022

Rebase with crossplane-contrib#1122, make reviewable green

5631f02

ytsarev mentioned this pull request Feb 20, 2022

feat(InstanceProfile): Add IAM InstanceProfile Managed Resource #1159

Merged

2 tasks

ytsarev added a commit to ytsarev/provider-aws that referenced this pull request Feb 20, 2022

Rebase with crossplane-contrib#1122, make reviewable green

240cc0d

Signed-off-by: Yury Tsarev <yury@upbound.io>

ytsarev added a commit to ytsarev/provider-aws that referenced this pull request Feb 20, 2022

Rebase with crossplane-contrib#1122, make reviewable green

a048ea3

Signed-off-by: Yury Tsarev <yury@upbound.io>

haarchri force-pushed the feature/ack-bump-sdk-1.42.0 branch from 85f5613 to deba226 Compare February 21, 2022 14:11

haarchri force-pushed the feature/ack-bump-sdk-1.42.0 branch from b155986 to 01c4352 Compare February 21, 2022 16:15

haarchri requested a review from muvaf February 21, 2022 16:15

goober mentioned this pull request Feb 22, 2022

OpenSearch support #1167

Closed

muvaf reviewed Feb 22, 2022

View reviewed changes

haarchri force-pushed the feature/ack-bump-sdk-1.42.0 branch from 01c4352 to a91e30c Compare March 6, 2022 12:44

haarchri requested a review from muvaf March 7, 2022 06:29

muvaf approved these changes Mar 7, 2022

View reviewed changes

apis/secretsmanager/v1alpha1/deprecated_secret.go Outdated Show resolved Hide resolved

examples/docdb/cluster.yaml Show resolved Hide resolved

examples/docdb/subnet-group.yaml Show resolved Hide resolved

pkg/controller/transfer/server/setup.go Show resolved Hide resolved

feat(ack): bump ack & aws go sdk v1 to 1.42.0

5098e0d

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri force-pushed the feature/ack-bump-sdk-1.42.0 branch from a19e007 to 5098e0d Compare March 7, 2022 09:39

feat(ack): e2e set timeout to 180s

650cf12

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri mentioned this pull request Mar 7, 2022

e2e test failed to get pre-cached package with pull policy Never crossplane/crossplane#2944

Closed

fix(e2e): set e2e tests to crossplane stable

1e4813f

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri merged commit cc8f87a into crossplane-contrib:master Mar 7, 2022

ytsarev added a commit to ytsarev/provider-aws that referenced this pull request Mar 7, 2022

Rebase with crossplane-contrib#1122, make reviewable green

f5e5a2a

Signed-off-by: Yury Tsarev <yury@upbound.io>

tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024

Merge pull request crossplane-contrib#1122 from ulucinar/remove-tf-cli

cd0b554

Remove the Terraform CLI from the provider package and deprecate the relevant provider command-line flags

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ack): bump ack & aws-go-sdk-v1 to 1.42.0 #1122

feat(ack): bump ack & aws-go-sdk-v1 to 1.42.0 #1122

haarchri commented Feb 6, 2022 •

edited

haarchri commented Feb 6, 2022

muvaf commented Feb 8, 2022

haarchri commented Feb 9, 2022

jbw976 commented Feb 19, 2022

haarchri commented Feb 19, 2022

haarchri commented Feb 20, 2022 •

edited

haarchri commented Feb 20, 2022

goober commented Feb 21, 2022 •

edited

haarchri commented Feb 21, 2022

haarchri commented Feb 21, 2022

muvaf left a comment

muvaf left a comment

haarchri commented Mar 7, 2022

haarchri commented Mar 7, 2022

feat(ack): bump ack & aws-go-sdk-v1 to 1.42.0 #1122

feat(ack): bump ack & aws-go-sdk-v1 to 1.42.0 #1122

Conversation

haarchri commented Feb 6, 2022 • edited

Description of your changes

How has this code been tested

haarchri commented Feb 6, 2022

muvaf commented Feb 8, 2022

haarchri commented Feb 9, 2022

jbw976 commented Feb 19, 2022

haarchri commented Feb 19, 2022

haarchri commented Feb 20, 2022 • edited

haarchri commented Feb 20, 2022

goober commented Feb 21, 2022 • edited

haarchri commented Feb 21, 2022

haarchri commented Feb 21, 2022

muvaf left a comment

Choose a reason for hiding this comment

muvaf left a comment

Choose a reason for hiding this comment

haarchri commented Mar 7, 2022

haarchri commented Mar 7, 2022

haarchri commented Feb 6, 2022 •

edited

haarchri commented Feb 20, 2022 •

edited

goober commented Feb 21, 2022 •

edited