Make eventThreshold an optional field for s3 bucket replication #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Last <alex.last@clearscore.com>
chlunde
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Tested without change, could not apply. Tested with PR, works. Thanks!
spec:
forProvider:
acl: private
@@ -54,11 +54,17 @@ spec:
storageClass: STANDARD
bucketRef:
name: repl-dest
+ metrics:
+ status: Enabled
+ replicationTime:
+ status: Disabled
+ time:
+ minutes: 15
deleteMarkerReplication:
status: Disabled
filter:
prefix: ""
- priority: 0
+ priority: 1
id: rule-1
status: Enabled
providerConfigRef:
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…e-cloudformation_stack_set_instance Add aws_cloudformation_stack_set_instance resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Last alexrichardlast@gmail.com
Description of your changes
Fixes #1117
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested