feat(s3): bucketKeyEnabled implemented

[haarchri]

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

implemented bucketKeyEnabled in sseConfig

Fixes #1154

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

t.b.d

[chlunde]

diff --git a/pkg/controller/s3/bucket/sseConfig.go b/pkg/controller/s3/bucket/sseConfig.go
index 93772cca..616e4105 100644
--- a/pkg/controller/s3/bucket/sseConfig.go
+++ b/pkg/controller/s3/bucket/sseConfig.go
@@ -75,6 +75,9 @@ func (in *SSEConfigurationClient) Observe(ctx context.Context, bucket *v1beta1.B
                if string(outputRule.SSEAlgorithm) != Rule.ApplyServerSideEncryptionByDefault.SSEAlgorithm {
                        return NeedsUpdate, nil
                }
+               if external.ServerSideEncryptionConfiguration.Rules[i].BucketKeyEnabled != Rule.BucketKeyEnabled {
+                       return NeedsUpdate, nil
+               }
        }
 
        return Updated, nil

perhaps also a test for this:

+               "NeedsUpdateEnableBucketKey": {
+                       args: args{
+                               b: s3testing.Bucket(s3testing.WithSSEConfig(generateSSEConfigWithBucketEncryption())),
+                               cl: NewSSEConfigurationClient(fake.MockBucketClient{
+                                       MockGetBucketEncryption: func(ctx context.Context, input *s3.GetBucketEncryptionInput, opts []func(*s3.Options)) (*s3.GetBucketEncryptionOutput, error) {
+                                               return &s3.GetBucketEncryptionOutput{ServerSideEncryptionConfiguration: generateAWSSSE()}, nil
+                                       },
+                               }),
+                       },
+                       want: want{
+                               status: NeedsUpdate,
+                               err:    nil,
+                       },
+               },

[haarchri]

e2e-tests are failing since we merged crossplane/crossplane#2932

using crossplane version 1.7.0-rc.0.125.gfff10011

kubectl get pkgrev
NAME                                                           HEALTHY   REVISION   IMAGE          STATE    DEP-FOUND   DEP-INSTALLED   AGE
providerrevision.pkg.crossplane.io/provider-aws-provider-aws             1          provider-aws   Active                               2m40s

Events:
  Type     Reason             Age                    From                                         Message
  ----     ------             ----                   ----                                         -------
  Normal   BindClusterRole    2m10s (x3 over 2m10s)  rbac/providerrevision.pkg.crossplane.io      Bound system ClusterRole to provider ServiceAccount(s)
  Normal   ApplyClusterRoles  2m10s (x2 over 2m10s)  rbac/providerrevision.pkg.crossplane.io      Applied RBAC ClusterRoles
  Warning  ParsePackage       9s (x8 over 2m10s)     packages/providerrevision.pkg.crossplane.io  failed to get pre-cached package with pull policy Never

tested locally with crossplane 1.6.3 without issues

[haarchri]

@chlunde rebased after sdk bump

[chlunde]

tested toggling on/off, reviewed, thanks!