Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2-tags): tags vpc/subnet default,add,delete #1170

Conversation

haarchri
Copy link
Member

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

  • added option to diff add/delete tags for vpc and subnet
  • added default crossplane tags in subnet

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

created
updated
deleted

@haarchri haarchri force-pushed the feature/ec2-vpc-subnet-tag-diff-default branch from 0242210 to 4787656 Compare February 22, 2022 16:28
…t tags

Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri force-pushed the feature/ec2-vpc-subnet-tag-diff-default branch from 4787656 to 3db430a Compare February 22, 2022 17:22
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants