Add Api Gateway RestAPI and Resource resources

[tiagoposse]

Description of your changes

Generate resources for the apigateway service and add restapi and resource as usable.
First part of #1185

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tests and example yamls included.

[stevendborrelli]

This looks like a nice PR!

When running the examples, I get the following issue parsing the policy:

.648561326001369e+09   DEBUG   provider-aws    Cannot observe external resource        {"controller": "managed/restapi.apigateway.aws.crossplane.io", "request": "/test", "uid": "e3724d47-b3c1-42ad-ba4c-b41c74cd46ff", "version": "237985", "external-name": "onnex4cv1b", "error": "late-init failed: policies couldnt be compared: cant parse policies: cant unmarshal policy: invalid character '\\\\' looking for beginning of object key string", "errorVerbose": "policies couldnt be compared: cant parse policies: cant unmarshal policy: invalid character '\\\\' looking for beginning of object key string\

 {"object": {"kind":"RestAPI","name":"test","uid":"e3724d47-b3c1-42ad-ba4c-b41c74cd46ff","apiVersion":"apigateway.aws.crossplane.io/v1alpha1","resourceVersion":"237985"}, "reason": "CannotObserveExternalResource", "message": "late-init failed: policies couldnt be compared: cant parse policies: cant unmarshal policy: invalid character '\\\\' looking for beginning of object key string"}

[stevendborrelli]

I need to dive deeper into the policy parsing, as I am getting errors in testing and there is some odd behavior about quoting.

[tiagoposse]

I managed to fix the policy parsing. For an explanation on what's happening:
A user will insert a policy like

{
	"Version": "2012-10-17",
	"Statement": [
		{
			"Effect": "Allow",
			"Principal": "*",
			"Action": "execute-api:Invoke",
			"Resource": "execute-api:/*/*/*"
		}
	]
}

but post-creation, aws will return

{\"Version\":\"2012-10-17\",\"Statement\":[{\"Action\":\"execute-api:Invoke\",\"Effect\":\"Allow\",\"Principal\":\"*\",\"Resource\":\"arn:aws:execute-api:eu-central-1:123456789012:abcdef1234/*/*/*\"}]}

This wasn't playing nice with json marshal/unmarshal. I found a solution that works here: https://stackoverflow.com/a/50151862. This substitutes the string replace approach.

[stevendborrelli]

@tiagoposse Thanks! The new fixes look like they resolve the parsing issue.

NAME                                        READY   SYNCED   EXTERNAL-NAME
restapi.apigateway.aws.crossplane.io/test   True    True     onnex4cv1b

NAME                                         READY   SYNCED   EXTERNAL-NAME
resource.apigateway.aws.crossplane.io/test   True    True     f2dndj

[stevendborrelli]

LGTM. Thanks for your contribution!

I have a small PR to your branch to fix a few errors. https://github.com/tiagoposse/provider-aws/pull/1

[tiagoposse]

My pleasure, looking forward to open PRs for rest of the resources once this is merged :)
Your fix branch is now merged

[stevendborrelli]

@tiagoposse do you think you could rebase this PR on master and push your branch? There was a linter fix in #1250 that we think is affecting the checks on this pR.

[tiagoposse]

done!

[tiagoposse]

Doesn't seem to have fixed it, anything else I can do here ?

[stevendborrelli]

I will pull your branch and see if there are any build issues in my environment. It's possible we still have issues in the GitHub action.

[stevendborrelli]

@tiagoposse I think the PR got caught up in some changes in the upstream API. I've opened a PR against your repo that hopefully fixes the issues: https://github.com/tiagoposse/provider-aws/pull/2

[stevendborrelli]

Looks like all the checks have passed. We'll need one of the maintainers to approve and merge.

[haarchri]

@stevendborrelli thanks for review testing and help with PRs ;) tested the resource also with success LGTM