fix(routetable): fix panic on sorting both v4 and v6 routes #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaspahomov <vas2142553@gmail.com> Signed-off-by: Jesse Suen <jessesuen@gmail.com>
haarchri
approved these changes
May 6, 2022
2 tasks
febarbosa182
pushed a commit
to febarbosa182/provider-aws
that referenced
this pull request
May 23, 2022
…ntrib#1279) Signed-off-by: vaspahomov <vas2142553@gmail.com> Signed-off-by: Jesse Suen <jessesuen@gmail.com> Co-authored-by: vaspahomov <vas2142553@gmail.com> Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rebase + conflict resolution of PR #893 which appears to be abandoned. Credit for this fix should go to @vaspahomov.
Signed-off-by: vaspahomov vas2142553@gmail.com
Signed-off-by: Jesse Suen jessesuen@gmail.com
Description of your changes
Fixes #795
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I was encountering the panic in #795 when creating route tables in a VPC with ipv6 enabled. The panic causes the provider-aws controller to crashloop and will not recover. With this fix, the panic no longer happens.