Adds the ARN to the AtProvider for the SNS Topic #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
reviewed
Sep 24, 2020
There was a problem hiding this comment.
Thanks @krishchow! One nitpick and could you sign your commit? :)
krishchow
force-pushed
the
SNSTopicARN
branch
from
90d175d
to
b1fd421
Compare
Signed-off-by: Krish Chowdhary <krish@redhat.com>
krishchow
force-pushed
the
SNSTopicARN
branch
from
b1fd421
to
bb6e45f
Compare
|
Fixed @hasheddan! :) |
hasheddan
approved these changes
Sep 25, 2020
26 tasks
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
Adds the ARN to the AtProvider for the SNS Topic
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
Adds the ARN to the AtProvider for the SNS Topic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #347
This PR just adds a field in the SNS Topic to store the ARN. The main reason this is important is so that when other functions require the ARN string, they can simply access the value in the status as opposed to querying the API.
Checklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.