Add OpenIDConnectProvider resource #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcavoyk
force-pushed
the
oidc-provider
branch
4 times, most recently
from
1884b88
to
a5a3382
Compare
mcavoyk
force-pushed
the
oidc-provider
branch
2 times, most recently
from
0aab913
to
b1f37f9
Compare
muvaf
approved these changes
May 24, 2021
mcavoyk
force-pushed
the
oidc-provider
branch
2 times, most recently
from
8f25755
to
9341bdc
Compare
|
Thanks @muvaf, I rebased and added an example. |
|
@mcavoyk Sorry, it seems like one of the PRs I merged made a change on the same file. Could you resolve the conflict? |
Signed-off-by: Kellin McAvoy <kmcavoy@ea.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #636
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Has controller tests and have e2e tested this resource by adding the oidcIssuer of an EKS cluster.