Bugfix/s3 website configuration #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack1902
force-pushed
the
bugfix/s3-website-configuration
branch
from
b6b4eec
to
f619107
Compare
muvaf
reviewed
May 5, 2021
jack1902
force-pushed
the
bugfix/s3-website-configuration
branch
from
23a2d11
to
11f8c8f
Compare
- Ensures protocol can be set blank as per the description - Fixes the website config to work when no routing rules are passed Signed-off-by: jack1902 <39212456+jack1902@users.noreply.github.com>
jack1902
force-pushed
the
bugfix/s3-website-configuration
branch
from
11f8c8f
to
020825c
Compare
muvaf
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Slack Thread: https://crossplane.slack.com/archives/CEF5N8X08/p1620143654284900
Fixes #650
I have:
make reviewable testto ensure this PR is ready for review.To Note, i have removed
protocolas a required parameter because even the description states it defaults to what the inbound request is yet the Spec states its required which goes against the given descriptionHow has this code been tested
I have been trying to use the website configuration on the bucket resource within a composition. I noticed that it worked if i passed routing rules but didn't when i only passed the index and error documents (things i have already done before in terraform but i am moving the bucket creation to crossplane 🚀 )
make test- ✅make e2e- ✅make reviewable- ✅make- ✅