Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CloudFront Distribution managed resource #654

Merged
merged 1 commit into from May 31, 2021
Merged

Add CloudFront Distribution managed resource #654

merged 1 commit into from May 31, 2021

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented May 6, 2021 •
edited

Description of your changes

This PR aims to introduce a managed resource for CloudFront's Distribution API.

Fixes #236

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.
  • Implement tests
  • Implement update logic

How has this code been tested

Manually deployed a distribution via v1alpha1.Distribution resource. Updated its comment field. Disabled and reenabled it and disabled it via its enabled field. Finally, deleted it.

@ulucinar
Copy link
Collaborator Author

Hi,
If you'd like I can happily do a quick demo to facilitate the reviews and discussions.

@ulucinar ulucinar requested review from muvaf, hasheddan and negz May 10, 2021 20:22
muvaf
muvaf reviewed May 11, 2021
View reviewed changes
apis/cloudfront/v1alpha1/zz_types.go Outdated Show resolved Hide resolved
pkg/controller/cloudfront/distribution/zz_controller.go Show resolved Hide resolved
pkg/controller/cloudfront/distribution/setup.go Outdated Show resolved Hide resolved
pkg/controller/cloudfront/distribution/setup.go Outdated Show resolved Hide resolved
pkg/controller/cloudfront/distribution/setup.go Outdated Show resolved Hide resolved
pkg/controller/cloudfront/distribution/setup.go Show resolved Hide resolved
pkg/clients/lateinit.go Outdated Show resolved Hide resolved
muvaf
muvaf reviewed May 25, 2021
View reviewed changes
pkg/clients/aws.go Outdated Show resolved Hide resolved
pkg/clients/lateinit.go Outdated Show resolved Hide resolved
muvaf
muvaf reviewed May 25, 2021
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulucinar Looks pretty close to merging, could you respond to the remaining comments?

muvaf
muvaf approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing that panic possibility and squashing to single commit. Thanks @ulucinar !

muvaf
muvaf reviewed May 26, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ulucinar
Add CloudFront Distribution managed resource
fb1a0c3 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@muvaf muvaf merged commit a9ffda9 into crossplane-contrib:master May 31, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
@hasheddan
Merge pull request crossplane-contrib#654 from hasheddan/official-doc…
f31bdd9 
…s-scrub

Update docs terminology and typos
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
@sergenyalcin
Merge pull request crossplane-contrib#654 from djeremiah/lambda-alias…
1faeb9c 
…-externalname

update the externalname configuration for aws_lambda_alias to reflect…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muvaf muvaf muvaf approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

@negz negz Awaiting requested review from negz

Assignees
No one assigned
Labels
new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CloudFront as a managed resource
2 participants
@ulucinar @muvaf