In the KMS generator config define a custom error for NotFoundException + regenerate code #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on + regenerate code In the API this is a 400 error, but we have to define it as a 404 error in the config, so the IsNotFound() function is generated correctly Signed-off-by: bandesz <andras.ferencz-szabo@appvia.io>
bandesz
force-pushed
the
fix_kms_key_controller
branch
from
c060188
to
7274546
Compare
bandesz
changed the title
muvaf
approved these changes
May 24, 2021
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…netes-patches Update kubernetes patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The KMS Key resource is broken and you can't create a KMS key with it. Fixes: #647
After looking at the code it seems the IsNotFound() function was generated incorrectly:
https://github.com/crossplane/provider-aws/blob/1ad7872a1b8f19cbd56f020e780ee698198163dc/pkg/controller/kms/key/zz_conversions.go#L147
I added a custom exception to the generator config. Although the API returns a 400 http code if the kms key does not exist, I still had to use 404 in the config, which seemed to do the trick.
I followed the instructions from CODE_GENERATION.md and ran these two commands:
In code-generator:
In provider-aws:
I'm not sure I generated the code correctly as there are more changes that I would expect.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I've built and deployed the provider to a real environment and tested KMS key creation, with and without an external-name.