s3: resolve bucket ARN in replication config references

[chlunde]

Description of your changes

The replication destination bucket should resolve to an ARN, not a bucket name.

Fixes #745

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

With blood, sweat and tears. Fixed three other issues first.

This is a "minimal" configuration (excluding role and policy):

---
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/external-name: repl-src.2021-06-07
  name: repl-src
spec:
  deletionPolicy: Delete
  forProvider:
    acl: private
    locationConstraint: eu-north-1
    paymentConfiguration:
      payer: BucketOwner
    serverSideEncryptionConfiguration:
      rules:
      - applyServerSideEncryptionByDefault:
          sseAlgorithm: AES256
    versioningConfiguration:
      status: Enabled
    replicationConfiguration:
      role: arn:aws:iam::...:role/s3-replication-test # assumable by s3 svc, I just tested with an s3 admin role
      rules:
      - destination:
          storageClass: STANDARD
          bucketRef:
            name: repl-dest
        deleteMarkerReplication:
          status: Disabled
        priority: 0
        id: rule-1
        status: Enabled
---
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  annotations:
    crossplane.io/external-name: repl-dest.2021-06-07
  name: repl-dest
spec:
  deletionPolicy: Delete
  forProvider:
    acl: private
    locationConstraint: eu-north-1
    paymentConfiguration:
      payer: BucketOwner
    serverSideEncryptionConfiguration:
      rules:
      - applyServerSideEncryptionByDefault:
          sseAlgorithm: AES256
    versioningConfiguration:
      status: Enabled

Question: Do you prefer the function returning a function for BucketARN?

[AaronME]

@chlunde, thank you for addressing #745

I'm getting the following error in my tests:

"cannot create or update: cannot put Bucket replication: MalformedXML: The XML you provided was not well-formed or did not validate against our published schema"

I used the following configuration:

---
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  name: repl-src
spec:
  deletionPolicy: Delete
  forProvider:
    acl: private
    locationConstraint: us-west-2
    paymentConfiguration:
      payer: BucketOwner
    serverSideEncryptionConfiguration:
      rules:
      - applyServerSideEncryptionByDefault:
          sseAlgorithm: AES256
    versioningConfiguration:
      status: Enabled
    replicationConfiguration:
      role: arn:aws:iam::...:role/role-name # assumable by s3 svc, I just tested with an s3 admin role
      rules:
      - destination:
          storageClass: STANDARD_IA
          bucketRef:
            name: repl-dest
        deleteMarkerReplication:
          Status: Disabled
        priority: 0
        id: rule-1
        status: Enabled
  providerConfigRef:
    name: example
---
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  name: repl-dest
spec:
  deletionPolicy: Delete
  forProvider:
    acl: private
    locationConstraint: us-west-2
    paymentConfiguration:
      payer: BucketOwner
    serverSideEncryptionConfiguration:
      rules:
      - applyServerSideEncryptionByDefault:
          sseAlgorithm: AES256
    versioningConfiguration:
      status: Enabled
  providerConfigRef:
    name: example

[chlunde]

Thanks for testing and reviewing this and the other PRs! I think you need a filter, or the filter PR, but I'm not certain.

I can check on monday.

[AaronME]

@chlunde, after merging the filter fix I successfully created the replicating bucket pair. Nice work!

Before merging, could you please:

1. Include the typo fix from s3: fix deleteMarkerReplication.Status -> deleteMarkerReplication.status #766 in this PR.
2. Update examples/s3/ with your test cases so we can run conformance testing on these changes.
3. Rebase on latest master.

Thanks again for this excellent contribution!

[chlunde]

I'm back to malformed policy unless i specify a filter, I don't understand why, because the SDK version is the same as before. Added filter to the example.

[AaronME]

@chlunde This works for me!

Thanks!

[AaronME]

@chlunde This works for me both with and without this filter.

[chlunde]

cool, do you want me to remove it or keep it as it is?