Test infrastructure should be run *by* Docker Compose, not other way round. #51
Comments
afandian
added a commit
that referenced
this issue
Feb 21, 2019
- Set up Elastic and Cayenne in Docker Compose. - Clojure code no longer automates Docker. - Instead of setting up and tearing down Docker Compose setup, now the test fixtures simply clear out the Elastic Search data. - Tests now use configuration values (not hard coded) for Elastic Search access. - Remove arbitrary sleeps in favour of explicitly flushing. This should be more deterministic, less error prone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test code (in the Clojure project) in the current Elastic Search branch automates Docker by spinning up containers. The code runs outside Docker. This will make it tricky to include in CI. It also means that the code isn't being tested isn't running in the target environment.
To bring the methodology into line with how we do Docker, all code should be run in the Docker container, managed with Docker Compose. The Clojure code should have no knowledge of Docker.
The text was updated successfully, but these errors were encountered: