Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on developing patches #2051

Open
c-grant opened this issue Oct 23, 2023 · 2 comments
Open

Question on developing patches #2051

c-grant opened this issue Oct 23, 2023 · 2 comments

Comments

@c-grant
Copy link
Contributor

c-grant commented Oct 23, 2023

Not an issues, but a question since I didn't see explicit guidance around this.

While trying to get the Ada Canadian Cross (Linux to windows to m68k bare metal) to compile I ran into a few issues with Ada source in GCC 10.5.0.
I pulled in specific line changes from a handful of files in GCC 11.4.0, but not necessarily a wholesale commit to diff between.
I made a patch file, stuffed it in with the rest of the 10.5.0 patches and all was successfully applied (for me) and the build no longer errors out.

Is this a kind of patch you would want comitted?

I can only really test it on the few configurations I'm building, which are all Canadian Crosses.

@QBos07
Copy link
Contributor

QBos07 commented Oct 27, 2023

Normaly we want to get fixes upstream but in cases of backporting it's ok.

@cpackham
Copy link
Contributor

Hard to say without seeing the patch. We're already carrying a lot of things that have been back-ported so I have no specific objection in principle. Feel free to raise a PR and we can go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants