Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Combine slider.tooltip.js files into js/thirdparty/ #866

Closed
zqzhang opened this issue Sep 10, 2014 · 5 comments
Closed

Combine slider.tooltip.js files into js/thirdparty/ #866

zqzhang opened this issue Sep 10, 2014 · 5 comments
Assignees

Comments

@zqzhang
Copy link
Contributor

zqzhang commented Sep 10, 2014

At #863, I find WRT people is trying to add slider.tooltip.js file to use-case test.

At current being, the crosswalk-test-suite contains several copies of slider.tooltip.js file, but they are not the same. Why not combine them together? For example, put it into <test-suite>/js/thirdparty/.

  • behavior/tests/2D3DAnimation/js/slider.tooltip.js
  • behavior/tests/CSSStyle/js/jquery/slider.tooltip.js
  • behavior/tests/MediaPlayback/js/jquery/slider.tooltip.js
  • behavior/tests/Vibration/js/jquery/slider.tooltip.js
  • usecase/webapi-usecase-tests/tests/AudioPlay/js/jquery/slider.tooltip.js
  • usecase/webapi-usecase-tests/tests/CSSStyle/js/jquery/slider.tooltip.js
  • usecase/webapi-usecase-tests/tests/Vibration/js/jquery/slider.tooltip.js
  • usecase/webapi-usecase-tests/tests/VideoPlayAndroid/js/jquery/slider.tooltip.js
  • usecase/webapi-usecase-tests/tests/VideoPlayTizen/js/jquery/slider.tooltip.js
  • usecase/webapi-usecase-tests/tests/WebGL/js/slider.tooltip.js
@zqzhang
Copy link
Contributor Author

zqzhang commented Sep 10, 2014

@Honry @JianfengXu please take care of this task, thanks.

@Honry
Copy link
Contributor

Honry commented Sep 11, 2014

hi, zhiqiang,

@yunxliu will take this task.

@zqzhang
Copy link
Contributor Author

zqzhang commented Sep 11, 2014

OK, at least unify these scripts (you may use a supper set of the code). Then we can go ahead #875

@zqzhang
Copy link
Contributor Author

zqzhang commented Nov 6, 2014

The solution at #923 is not so good. Still needs to rethink of this problem.

@zqzhang zqzhang self-assigned this Feb 3, 2015
@zqzhang
Copy link
Contributor Author

zqzhang commented Dec 11, 2015

Seems no urgent fixing for this, close it as is. Feel free to report JIRA task if you want to make it.

@zqzhang zqzhang closed this as completed Dec 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants