Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font preferences work in a strange way #1070

Open
dkuteynikov opened this issue Jan 17, 2021 · 3 comments
Open

Font preferences work in a strange way #1070

dkuteynikov opened this issue Jan 17, 2021 · 3 comments

Comments

@dkuteynikov
Copy link

Built the latest Xiphos from git, master branch, commit ece84a4
Ubuntu 20.04.1 LTS
Go to Edit -> Preferences -> Fonts -> Sizes and Faces
When you select a language, a dialog appears where you can select a font scale factor. After you select the font size and press OK, the result is NOT displayed in the preferences window. So if you dislike how the text started to look, you cannot simply change the value again. Instead, the only way is to select some other language, cancel a dialog that will appear, then return back to the language which you intended to fix and finally change the size in a new dialog.

prefs
font

@karlkleinpaste
Copy link
Contributor

i'm open to concrete coding suggestions.
the problem is that gtk's mechanism for combo box sends a signal for handling only when the item selected changes. once a particular language is displayed, there's no way to generate a new indication for handling without changing what's selected.

@dkuteynikov
Copy link
Author

Can't you just get rid of the extra dialog and embed it's content into the Size & Faces window? For example, it could look like this:

Font Sizes
Base font size [+2]
Verse number size [+0]
Font preferences, per language [Greek]
abc Change font for Language
[None] [+0]
[✓] Use the default font for this module

When everything is located in one window, there will be no need to make some magic with the dialogs to change the font. A user will simply change it in-place, below the combobox.

@alerque
Copy link
Contributor

alerque commented Jan 18, 2021

This is a duplicate of #911. The UI needs to either move to a single dialog like @dkuteynikov suggested or a button needs to be added after the combo box widget for "edit" and the signal needs to move from "on change" on the combo box to "on press" on the edit button. The combo box by itself is simply not suited for the use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants