Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] addOnlineUser fails for users with localized usernames #2131

Closed
1 task done
mgway opened this issue Mar 27, 2023 · 1 comment
Closed
1 task done

[Bug] addOnlineUser fails for users with localized usernames #2131

mgway opened this issue Mar 27, 2023 · 1 comment
Labels
Bug A defect in the app
Projects
Work Status

Comments

@mgway
Copy link
Contributor

mgway commented Mar 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Localized usernames (i.e. those containing non-ascii characters) can't be looked up using the Twitch users API, so addOnlineUser fails. Presumably the user's login should be used with this API call instead of the localized/display name. Presumably not related to #2123 as there's no extra space/%20 after the username

(apologies, I only have a screenshot of the log)

image

Expected Behavior

No response

Steps To Reproduce

No response

Version

v5.57.0

What operating system are you using Firebot on?

Windows 10

Relevant log output

No response

Contact Details (Optional)

No response
@mgway mgway added the Bug A defect in the app label Mar 27, 2023
@github-actions github-actions bot added this to Backlog in Work Status Mar 27, 2023
@CKY-
Copy link
Collaborator

CKY- commented Mar 28, 2023

it is part of #1247

@zunderscore zunderscore moved this from Backlog to Release Pending in Work Status Feb 7, 2024
@github-actions github-actions bot added Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Feb 7, 2024
@SReject SReject closed this as completed Feb 16, 2024
Work Status automation moved this from Release Pending to Closed Feb 16, 2024
@github-actions github-actions bot removed Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A defect in the app
Projects
Work Status
  
Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgway @SReject @CKY-