Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selector restriction when creating group #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ockam
Copy link

@ockam ockam commented Feb 27, 2018

Removing the img selector restriction allows to use v-img on other elements. As in:

<div v-img="{group: 'myGroup', src: 'path/to/image.jpg'}"></div>

This could resolve #27.

Not sure if this can have side effects on the rest of the library, but it works fine for me.

@ockam
Copy link
Author

ockam commented Feb 27, 2018

Oups. Just noticed I reproduced PR #42... 🤷‍♂️

@fahrenq
Copy link
Contributor

fahrenq commented Feb 28, 2018

Hi @ockam!

Than you very much anyway!

Sorry, don't have time yet to resolve all issues and PRs, I'll come and continue working on the plugin shortly :)

Thanks!

@simonbrunel
Copy link

@fahrenq it looks like this PR is much easier to review than #42 since it focuses on removing the <img> restriction (1 line change). Do you need anything else to be able to review, merge and release these changes? Can we help in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of custom components with src attribute.
3 participants