Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip shortcodes from content before creating default broadcast #122

Closed
alexkingorg opened this issue Nov 4, 2012 · 4 comments
Closed
Labels
Milestone

Comments

@alexkingorg
Copy link
Contributor

http://wordpress.org/support/topic/brackets-show-in-twitter-post

@jondavidjohn
Copy link
Contributor

@alexkingorg

2 options here...

https://github.com/crowdfavorite/wp-social/blob/master/lib/social/service.php#L411-L415

We can either strip_shortcodes($post->post_content) or do_shortcodes($post->post_content) the content as the first step here... part of me thinks the do_shortcodes() is more expected, obviously we're stripping tags here also so any shortcode that produces tags wouldn't have an impact, but if a shortcode is producing content, it will carry through in the broadcast.

Thoughts?

@alexkingorg
Copy link
Contributor Author

Agreed, let's "do". We're stripping tags as part of the cleanup so we don't need to worry about junking things up that way.

@jondavidjohn
Copy link
Contributor

@alexkingorg
Copy link
Contributor Author

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants