Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cowboy to a supervision tree #31

Closed
CrowdHailer opened this issue Feb 23, 2017 · 2 comments
Closed

Adding Cowboy to a supervision tree #31

CrowdHailer opened this issue Feb 23, 2017 · 2 comments

Comments

@CrowdHailer
Copy link
Owner

The cowboy adapter currently cannot be started under a project applications supervision tree.

Cowboy, by design, starts a server under its application supervision tree when using :cowboy.start_http/4.

It is possible to start it under a project supervisor. and we would like to add that functionality to the cowboy adapter.

See:

@CharlesOkwuagwu
Copy link
Contributor

Ok cool, so we switch to cowboy.child_spec. That would be better.

@CrowdHailer
Copy link
Owner Author

@CharlesOkwuagwu I have opened a PR #35 to tackle this. It's not using child_spec but I think an even better solution of just defining a start_link function. This is better because it allows you to start a application directly, useful for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants