Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated defaultProjectId property from TM resource #111

Closed
andrii-bodnar opened this issue Mar 16, 2023 · 1 comment · Fixed by #139
Closed

Remove deprecated defaultProjectId property from TM resource #111

andrii-bodnar opened this issue Mar 16, 2023 · 1 comment · Fixed by #139
Assignees
@innomaxx
Labels
good first issue Good for newcomers

Comments

@andrii-bodnar
Copy link
Member

andrii-bodnar commented Mar 16, 2023 •
edited
Loading

This property was removed from the API:

https://github.com/crowdin/crowdin-api-client-dotnet/search?q=defaultProjectId

Also, the defaultProjectIds property is missing, it should be added. https://developer.crowdin.com/api/v2/#operation/api.tms.get
@andrii-bodnar andrii-bodnar added the good first issue Good for newcomers label Mar 16, 2023
@innomaxx innomaxx self-assigned this May 17, 2023
@innomaxx
Copy link
Collaborator

The code search from the first URL also covers Glossary section where is the same situation : property defaultProjectId (integer) is replaced with defaultProjectIds (array of integers). Should we also make changes here?

@innomaxx innomaxx mentioned this issue May 17, 2023
Merged
@innomaxx innomaxx mentioned this issue May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@innomaxx innomaxx

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API Updates: TM: replace deprecated property "defaultProjectId" crowdin/crowdin-api-client-dotnet
2 participants
@andrii-bodnar @innomaxx