Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects API: qaChecksIgnorableCategories support #113

Closed
andrii-bodnar opened this issue Mar 30, 2023 · 6 comments · Fixed by #134
Closed

Projects API: qaChecksIgnorableCategories support #113

andrii-bodnar opened this issue Mar 30, 2023 · 6 comments · Fixed by #134
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andrii-bodnar
Copy link
Member

Crowdin Rest API now supports the qaChecksIgnorableCategories field on the Projects API.

This field allows you to retrieve the list of QA Check categories that can be ignored for a Crowdin project.

Affected API methods:

It should be reflected in this API client and the corresponding unit tests should be updated.

@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers labels Mar 30, 2023
@innomaxx innomaxx self-assigned this May 10, 2023
@innomaxx
Copy link
Collaborator

@andrii-bodnar type of qaChecksIgnorableCategories is the same that of qaCheckCategories? Seems like props are the same

@innomaxx
Copy link
Collaborator

Also in docs I noticed new properties in qaCheckCategories model that are also exist in qaChecksIgnorableCategories
But these props are not available in API client yet. Should we also add them?

image

@andrii-bodnar
Copy link
Member Author

@andrii-bodnar type of qaChecksIgnorableCategories is the same that of qaCheckCategories? Seems like props are the same

Please provide the API methods as a reference, probably it's the same, but need to check additionally

@andrii-bodnar
Copy link
Member Author

Also in docs I noticed new properties in qaCheckCategories model that are also exist in qaChecksIgnorableCategories But these props are not available in API client yet. Should we also add them?

Nice catch, these are new types that have been added recently, they should be reflected in the API client as well

@innomaxx
Copy link
Collaborator

Please provide the API methods as a reference, probably it's the same, but need to check additionally

It's Add Project method

@andrii-bodnar
Copy link
Member Author

type of qaChecksIgnorableCategories is the same that of qaCheckCategories? Seems like props are the same

yes, it's the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants