Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoTag on existing screenshots is not supported #204

Closed
djbb7 opened this issue Nov 7, 2022 · 2 comments · Fixed by #222
Closed

autoTag on existing screenshots is not supported #204

djbb7 opened this issue Nov 7, 2022 · 2 comments · Fixed by #222
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@djbb7
Copy link

djbb7 commented Nov 7, 2022

Using the API (https://developer.crowdin.com/api/v2/#operation/api.projects.screenshots.tags.putMany) it is possible to autoTag an existing image by providing the body:

{
  "autoTag": true
}

However, the js client only supports passing the list of tags that should be added (https://github.com/crowdin/crowdin-api-client-js/blob/master/src/screenshots/index.ts#L147)

    replaceTags(projectId: number, screenshotId: number, request: ScreenshotsModel.AddTagRequest[]): Promise<void> {
        const url = `${this.url}/projects/${projectId}/screenshots/${screenshotId}/tags`;
        return this.put(url, request, this.defaultConfig());
    }

The signature of the replaceTags method should be updated so that autoTag is also supported.

@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers labels Nov 7, 2022
@andrii-bodnar
Copy link
Member

Hi @djbb7!
Thanks for your request and sorry for this inconvenience. We will look into that.
Anyway, we are also open for contributions 🙂

@yevheniyJ yevheniyJ linked a pull request Jan 21, 2023 that will close this issue
@yevheniyJ
Copy link
Collaborator

Fixed in v1.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants