Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md image does not load on coming back from another file. #164

Closed
faizan1191 opened this issue Oct 22, 2023 · 6 comments
Closed

Readme.md image does not load on coming back from another file. #164

faizan1191 opened this issue Oct 22, 2023 · 6 comments

Comments

@faizan1191
Copy link
Contributor

faizan1191 commented Oct 22, 2023

Screenshot (3)
The Readme. md image does not load on coming back from another file.

Note - Issue only in Github 'Default Dark' theme.

First, go to the repository home page where you will see the readme contents below, now go to any file and come back again to see the readme file doesn't load this time. I tried something by removing specific images for a light theme but that doesn't work cause now it shows light theme images in dark theme settings.
I am working on it and will find out what's the issue.

Note - Checked the Github doc for adding theme-specific images and found that we are doing it correctly. (https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to)

@andrii-bodnar
Copy link
Member

@faizan1191 thank you for reporting this! Just pushed the fix - 3efcf3b

Could you please confirm that it's working for you now?

@faizan1191
Copy link
Contributor Author

@andrii-bodnar now image is showing on coming back after viewing any file but the image shown is light theme's preference image.
Actual
Screenshot_2023-10-23-12-35-45-060_com android chrome
Expected
Screenshot_2023-10-23-12-35-45-060_com android chrome

@faizan1191
Copy link
Contributor Author

Sorry actual image:
Screenshot_2023-10-23-12-35-20-083_com android chrome

@andrii-bodnar
Copy link
Member

@faizan1191 just checked it and it works as expected for me:

Screenshot 2023-10-23 at 11 09 44

Screenshot 2023-10-23 at 11 10 12

@faizan1191
Copy link
Contributor Author

@andrii-bodnar
Copy link
Member

@faizan1191 this looks like a GitHub bug and is unfortunately out of my control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants