Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty strings when using skip_untranslated_strings #497

Closed
nicolas-godefroy-dev opened this issue Oct 20, 2022 · 4 comments
Closed

Empty strings when using skip_untranslated_strings #497

nicolas-godefroy-dev opened this issue Oct 20, 2022 · 4 comments
Labels
bug import/export Related to files import/export functionality in Crowdin. Probably is not a CLI problem

Comments

@nicolas-godefroy-dev
Copy link

Describe the bug
I'm having the same problem described in #457 I updated my config file to use the skip_untranslated_strings: true option, however when I run the crowdin download via crowdin github action the download files come with a bunch of empty strings where there is no translation yet.

Expected behavior
Terms without translations should not be present, instead of coming with an empty string.

Environment:
Crowdin CLI via github action
Environment:

  • OS: Ubuntu
  • Version latest

Screenshots
Screenshot 2022-10-20 at 13 46 41

@andrii-bodnar andrii-bodnar added the import/export Related to files import/export functionality in Crowdin. Probably is not a CLI problem label Oct 20, 2022
@OlenkaCrowdin
Copy link

Hi @nicolas-godefroy-dev!

Could you please share the link to the project in Crowdin as well?

@nicolas-godefroy-dev
Copy link
Author

Hi @nicolas-godefroy-dev!

Could you please share the link to the project in Crowdin as well?

Hi, sure https://bounce.crowdin.com/u/projects/5.

@OlenkaCrowdin
Copy link

Dear @nicolas-godefroy-dev ,

We have applied the special post-processor for your project - as a result, the untranslated strings should be trimmed completely from the exported JSON files now.

Would you please try to download the translations once again and let me know how it goes? :)

@nicolas-godefroy-dev
Copy link
Author

Dear @nicolas-godefroy-dev ,

We have applied the special post-processor for your project - as a result, the untranslated strings should be trimmed completely from the exported JSON files now.

Would you please try to download the translations once again and let me know how it goes? :)

It works, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug import/export Related to files import/export functionality in Crowdin. Probably is not a CLI problem
Projects
None yet
Development

No branches or pull requests

3 participants