New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SocketAPI to use 4.0.4 Starscream #168
Conversation
Hi @alexookah, thanks a lot for your contribution! |
@alexookah, just merged another pull request related to the Starscream (#166) and it appears that there are some conflicts. Could you please rebase your branch? |
@andrii-bodnar I just rebased my branch with your recent changes |
@alexookah great, thank you! |
@alexookah could you please also check the failed build? |
@andrii-bodnar just made another commit to update Starscream version 4.0.4 also for pods |
@andrii-bodnar Now the build is successfull. |
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 55.94% 55.94%
=======================================
Files 118 118
Lines 4019 4019
=======================================
Hits 2248 2248
Misses 1771 1771
Continue to review full report at Codecov.
|
@serhii-londar Can you have a look in the MR? It's currently blocking us to use the SDK in our app because the dependency Starscream version is older. #167 |
@alexookah we have passed this to our QA team and after testing, we will release a new iOS SDK version. |
This MR updates crowdin dependency of Starscream usages to version 4.0.4.
This should resolve the issue: #167
(4.0.4 also removes the extra dependency added from Starscream: swift-nio-zlib-support)
Feel free to ask something about my changes if you like.