Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SocketAPI to use 4.0.4 Starscream #168

Merged
merged 6 commits into from Feb 9, 2022
Merged

Update SocketAPI to use 4.0.4 Starscream #168

merged 6 commits into from Feb 9, 2022

Conversation

alexookah
Copy link
Contributor

@alexookah alexookah commented Feb 8, 2022

This MR updates crowdin dependency of Starscream usages to version 4.0.4.

This should resolve the issue: #167
(4.0.4 also removes the extra dependency added from Starscream: swift-nio-zlib-support)

Feel free to ask something about my changes if you like.

@alexookah alexookah changed the title Update WebSocketService to use 4.0.4 Starscream Update SocketAPI to use 4.0.4 Starscream Feb 8, 2022
@andrii-bodnar
Copy link
Member

Hi @alexookah, thanks a lot for your contribution!

@andrii-bodnar
Copy link
Member

@alexookah,  just merged another pull request related to the Starscream (#166) and it appears that there are some conflicts. Could you please rebase your branch?

@alexookah
Copy link
Contributor Author

@andrii-bodnar I just rebased my branch with your recent changes

@andrii-bodnar
Copy link
Member

@alexookah great, thank you!

@andrii-bodnar
Copy link
Member

@alexookah could you please also check the failed build?

@alexookah
Copy link
Contributor Author

@andrii-bodnar just made another commit to update Starscream version 4.0.4 also for pods

@alexookah
Copy link
Contributor Author

@andrii-bodnar Now the build is successfull.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #168 (78588e7) into master (0db8be3) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   55.94%   55.94%           
=======================================
  Files         118      118           
  Lines        4019     4019           
=======================================
  Hits         2248     2248           
  Misses       1771     1771           
Impacted Files Coverage Δ
...rces/CrowdinSDK/CrowdinSDK/Extensions/Locale.swift 86.37% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db8be3...78588e7. Read the comment docs.

@alexookah
Copy link
Contributor Author

@serhii-londar Can you have a look in the MR? It's currently blocking us to use the SDK in our app because the dependency Starscream version is older. #167

@serhii-londar serhii-londar merged commit ef94703 into crowdin:master Feb 9, 2022
@andrii-bodnar
Copy link
Member

@alexookah we have passed this to our QA team and after testing, we will release a new iOS SDK version.

@andrii-bodnar andrii-bodnar linked an issue Feb 9, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPM starscream dependency should use latest version 4.0.4
3 participants