[WIP] LAPI->CAPI : Support new data #1011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blotus
reviewed
Oct 18, 2021
| ShareManualDecisions *bool `yaml:"share_manual_decisions"` | ||
| ShareTaintedScenarios *bool `yaml:"share_custom"` | ||
| ShareCustomScenarios *bool `yaml:"share_tainted"` | ||
| ShareDecisions *bool `yaml:"share_decisions"` |
There was a problem hiding this comment.
Probably rename to something like share_deleted_decisions to avoid confusion with the actual signal sharing.
blotus
reviewed
Oct 18, 2021
AlteredCoder
force-pushed
the
lapi_to_capi
branch
from
56d3861
to
740b302
Compare
AlteredCoder
force-pushed
the
lapi_to_capi
branch
from
504cd3a
to
d50ea5f
Compare
buixor
changed the title
|
This PR only have the sharing decisions feature that is not in crowdsec master. This feature will be implemented later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cscli console enrollnote This PR has been split and partially merged for 1.3 (support of tainted/custom/manual decisions for console).