Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captcha redirect issue #58

Open
LaurenceJJones opened this issue Jan 24, 2024 · 0 comments
Open

Captcha redirect issue #58

LaurenceJJones opened this issue Jan 24, 2024 · 0 comments

Comments

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Jan 24, 2024

When a user completes the captcha they are meant to be redirected to the last known URI they requested, however, the current implemented presumes that a single IP with have a single user. So if another request comes from another users on the same IP the original requester will get redirected to another location.

Security Concerns

So this might spark ideas of session hijacking if the application holds sensitive information within the query string. However, we only store ngx.var.uri which is normalised to only be the base path with everyelse stripped.

Fix

So the optimal solution is generating session ID which is used within a cookie that is sent on captcha completion this is how we would know which URL is which session without relying heavily on just the IP address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant