Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add logging spring boot starter #102

Merged
merged 4 commits into from Apr 26, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.3.0
  • Module:
    nrich-logging

Additional information

Description

Summary

Added Spring Boot starter module for nrich-logging, changed nrich-webmvc-spring-boot-starter dependencies to use that starter instead of manually creating LoggingService bean.

Details

Added Spring Boot starter module for nrich-logging, changed nrich-webmvc-spring-boot-starter dependencies to use that starter instead of manually creating LoggingService bean.

Related issue

#32

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Apr 22, 2022
@agrancaric agrancaric force-pushed the feature_addLoggingSpringBootStarter branch from c822a83 to fa8ec6f Compare April 22, 2022 08:42
@agrancaric agrancaric linked an issue Apr 22, 2022 that may be closed by this pull request
@agrancaric agrancaric force-pushed the feature_addLoggingSpringBootStarter branch from fa8ec6f to 4c3c370 Compare April 26, 2022 08:39
@jzrilic
Copy link
Collaborator

jzrilic commented Apr 26, 2022

There is a typo in third commit message -> Implement Spring Boot autocnfiguration for nrich-logging

@jzrilic
Copy link
Collaborator

jzrilic commented Apr 26, 2022

Switch nrich-webmvc-spring-boot-starter modules dependencies to new nrich-logging-spring-boot-starter module and adjust tests - I think it should be module instead of modules here. Additionally, we can omit and adjust tests part.

@agrancaric agrancaric force-pushed the feature_addLoggingSpringBootStarter branch from 4c3c370 to 3a5b325 Compare April 26, 2022 10:51
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #102 (4c3c370) into master (e391859) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c3c370 differs from pull request most recent head c5953ea. Consider uploading reports for the commit c5953ea to get more accurate results

@@            Coverage Diff            @@
##             master     #102   +/-   ##
=========================================
  Coverage     96.15%   96.15%           
- Complexity     1022     1023    +1     
=========================================
  Files           152      153    +1     
  Lines          2446     2447    +1     
  Branches        225      225           
=========================================
+ Hits           2352     2353    +1     
  Misses           35       35           
  Partials         59       59           
Impacted Files Coverage Δ
...er/configuration/NrichWebMvcAutoConfiguration.java 100.00% <ø> (ø)
...r/configuration/NrichLoggingAutoConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e391859...c5953ea. Read the comment docs.

@agrancaric agrancaric force-pushed the feature_addLoggingSpringBootStarter branch from 3a5b325 to 075564a Compare April 26, 2022 11:14
@agrancaric agrancaric requested a review from jzrilic April 26, 2022 11:14
Copy link
Collaborator

@jzrilic jzrilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok now.

@agrancaric agrancaric force-pushed the feature_addLoggingSpringBootStarter branch from 075564a to c5953ea Compare April 26, 2022 12:03
@jzrilic jzrilic merged commit e9ed84f into master Apr 26, 2022
@jzrilic jzrilic deleted the feature_addLoggingSpringBootStarter branch April 26, 2022 12:19
@jsajlovic jsajlovic added this to the v1.4.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a Spring Boot starter module for nrich-logging
3 participants