Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6, add support for 3.6 #471

Closed
wants to merge 5 commits into from
Closed

Drop support for EOL Python 2.6, add support for 3.6 #471

wants to merge 5 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 28, 2017

Fixes #426.

@codecov-io
Copy link

codecov-io commented Oct 28, 2017

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #471   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     13    -1     
  Lines        3385   3372   -13     
  Branches      235    235           
=====================================
- Hits         3385   3372   -13
Impacted Files Coverage Δ
arrow/util.py 100% <ø> (ø) ⬆️
arrow/parser.py 100% <100%> (ø) ⬆️
arrow/arrow.py 100% <100%> (ø) ⬆️
tests/arrow_tests.py 100% <100%> (ø) ⬆️
arrow/factory.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67fb5c...b4f6211. Read the comment docs.

@ramonsaraiva
Copy link
Contributor

I'm not entirely sure if we should drop the usage of indexes in format for every single case. What do you guys think @Syeberman @andrewelkins ?

@hugovk
Copy link
Contributor Author

hugovk commented May 21, 2018

Rebased on master to resolve conflicts.

Here's the pip installs for arrow from PyPI for April 2018:

python_version percent download_count
3.6 71.02% 629,512
2.7 22.49% 199,330
3.5 4.04% 35,802
3.4 2.35% 20,846
3.7 0.04% 376
2.6 0.04% 346
3.3 0.01% 117
3.8 0.00% 2
Total 886,331

Source: pypinfo --start-date 2018-04-01 --end-date 2018-04-30 --percent --pip --markdown arrow pyversion

@hugovk
Copy link
Contributor Author

hugovk commented Jul 27, 2018

Closing in favour of PR #472.

@hugovk hugovk closed this Jul 27, 2018
@hugovk hugovk deleted the rm-2.6 branch July 27, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants