Django's HttpResponse object has deprecated the mimetype kwarg in 1.7 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, now content_type
|
The same patch in #80. What is needed to get this patch applied? Django 1.7 is going to be release very soon now.... Thanks |
crucialfelix
added a commit
that referenced
this pull request
Jul 24, 2014
Django's HttpResponse object has deprecated the mimetype kwarg in 1.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mimetypekwarg has been deprecated in favour ofcontent_typewhich has been present in Django since 1.4. (see https://docs.djangoproject.com/en/1.7/ref/request-response/#id3)https://docs.djangoproject.com/en/1.4/ref/request-response/
content_type is an alias for mimetype. Historically, this parameter was only called mimetype, but since this is actually the value included in the HTTP Content-Type header, it can also include the character set encoding, which makes it more than just a MIME type specification. If mimetype is specified (not None), that value is used. Otherwise, content_type is used. If neither is given, the DEFAULT_CONTENT_TYPE setting is used.
This change will break backwards compatibility with Django 1.3 and earlier.