feat(files): #7 Option to disable file creation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugosenari
commented
Feb 18, 2023
| @@ -8,6 +8,7 @@ They are already included when we use this package. | |||
| - `files.cmds`, install packages from [nix repository](https://search.nixos.org/) | |||
| - `files.docs`, convert our modules file into markdown using [nmd](https://gitlab.com/rycee/nmd) | |||
| - `files.git`, configure git with file creation | |||
| - `files.on-call`, connfigure file to created only when devshell-files command is called, not on shell start | |||
There was a problem hiding this comment.
@adrian-gierakowski I'm not good at naming things, suggestions?
There was a problem hiding this comment.
create-on-entercreate-on-startupcreate-on-shell-start
Maybe should be camelCase though? The case usage seems a bit inconsistent in nixos module options, but I'd usually use kebab-case only when the value is expected to be a package, since the name would often correspond to executable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7
If or some reason one line to enter the shell but not create the file, now there is an option