Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iOS 7 light status bar #15

Closed
MrMatthewDavis opened this issue Feb 18, 2014 · 8 comments
Closed

Add support for iOS 7 light status bar #15

MrMatthewDavis opened this issue Feb 18, 2014 · 8 comments

Comments

@MrMatthewDavis
Copy link

When using a white status bar, the text goes black right before the notifications show until right after they disappear and then flashes back to white.

@cruffenach
Copy link
Owner

Thanks for creating an issue, I'll take a look at this tomorrow.

@phillipthelen
Copy link
Collaborator

I gave this issue a shot and almost solved it. I can already set the color of the status bar to black or white for the notification. Unfortunately I currently can't figure out how to get the old color. Does anybody maybe have an idea where the old color could be accessed?

Edit:
As a workaround I made an option available to set the status bar color. https://github.com/vIiRuS/CRToast/commit/e85576e81d1336a224e86ef16b55943fa564ab15

@MrMatthewDavis
Copy link
Author

@cruffenach Any progress on this issue?

@Viirus how would I be able to integrate your fork into my project using pods?

EDIT: I manually copied @Viirus 's changes into the default CRToast files (for simplicity since I'm using pods), and set
kCRToastStatusBarStyle : @(UIStatusBarStyleLightContent) in the options dictionary and it worked for me. In my case, the status bar will always have white text so I don't need to programmatically determine the style of the status bar. This solution works great, and I suggest submitting a pull request for these additions (plus that way pods doesn't override my changes on an update).

@ipetkov
Copy link

ipetkov commented Mar 8, 2014

@mad102190 You can always specify what repo, branch, and commit to use in your podfile like

pod 'CRToast', :git => 'https://github.com/vIiRuS/CRToast.git', :commit => 'e85576e81d'

Check out the cocoapods guides for more podfile options.

@chourobin
Copy link
Contributor

+1. Thanks for sharing your workaround.

@dexcell
Copy link

dexcell commented Apr 23, 2014

@cruffenach
Please merge this into main CRToast code
Thank you.

@cruffenach
Copy link
Owner

@dexcell I did merge it I believe --> 4e0fdd3

@chourobin
Copy link
Contributor

@cruffenach Yup i think this issue can be closed. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants