Don't ignore globs when skipping files for update #296
Conversation
RobertDeRose
force-pushed
the
bugfix/glob-skips-are-ignored
branch
from
2310971
to
0528754
Compare
The logic in `_remove_paths` checks if the path is a `str` or `Path` object and only if it is a `str` does it assume it contains a glob. Unfortunately, the `_get_skip_paths` method was wrapping all returned values in `Path` objects so globs were being ignored.
RobertDeRose
force-pushed
the
bugfix/glob-skips-are-ignored
branch
from
0528754
to
d08b290
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 99.71% 99.72% +0.01%
==========================================
Files 21 21
Lines 1050 1094 +44
==========================================
+ Hits 1047 1091 +44
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
@millsks You made the last commit 9 months ago. Is this project dead? This is the second PR to address this issue, I didn't see #258 which has been open since June 2023. I think my PR addresses the issue a little more closely to the current code style, with proper type hints, but one of these needs to be merged as it's a broken feature. |
|
Hi Robert. I do not believe this project is dead. I just got side tracked by a move recently and trying to get everything situated again. I would say your PR would supercede mine if it takes unto account the latest code style. |
Completely understood. Would appreciate a merge if this meets the maintainers satisfaction. |
The logic in
_remove_pathschecks if the path is astrorPathobject and only if it is astrdoes it assume it contains a glob. Unfortunately, the_get_skip_pathsmethod was wrapping all returned values inPathobjects so globs were being ignored.Fixes #295
Closes #258