Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a license #7

Closed
urbanslug opened this issue Apr 22, 2020 · 3 comments
Closed

Add a license #7

urbanslug opened this issue Apr 22, 2020 · 3 comments

Comments

@urbanslug
Copy link

urbanslug commented Apr 22, 2020

Could just be me but what's the license on this project? Could it be made explicit?

The package.json has private set to true but according to the package.json spec that's not a license.
"Consider also setting "private": true to prevent accidental publication."

Edit:
Just ran the project and the bottom of the page says "Made by Cruip. All right reserved" so I guess it's not public. It would still be nice if it was clearer.

Edit 2:
FWIW: The name open-react-template is quite misleading given it's not (that) open.

@marcolino
Copy link

I agree totally. Please be more explicit...

@pasqualevitiello
Copy link
Contributor

The license is specified in the README.md file: https://github.com/cruip/open-react-template#terms-and-license

@Zenahr
Copy link

Zenahr commented Aug 29, 2020

@pasqualevitiello usually you can add a LICENSE.md file which makes it so that people see the license used right away. It's common practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants