Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making PastelView more Objc compatible. #9

Merged
merged 1 commit into from May 18, 2017

Conversation

kgellci
Copy link
Contributor

@kgellci kgellci commented May 16, 2017

Currently PastelView is not fully objc compatible because of the Point enum.

I made several changes to make it compatible and maintain the full original functionality:

  • Point enum renamed to PastelPoint and custom case with associated type removed.

  • startPoint and endPoint properties are now CGPoint allowing for setting custom points without enum

  • Added startPastelPoint and endPastelPoint properties to PastelView which will set the startPoint and endPoint CGPoint properties from their didSet methods.

  • Changed method definition for setColors and addColor for better readability when using. *not needed for the objc support.

  • Changed code in Readme to reflect changes.

With these changes, PastelView is fully usable in objc out of the box.

… objc compatible and renaming to Pastel Point.
@cruisediary
Copy link
Owner

thank you @kgellci work fine :D 💯

@cruisediary cruisediary merged commit 25d3207 into cruisediary:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants