-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.1 breaks dynamic Chart.yaml names #507
Comments
Is this an application part of an app of apps? You're running it through lovely-vault? I wonder if lovely-vault is broken - are there any logs from the container other than this? |
yes - application is part of an app of apps. I have also looked at the changelog and could not see anything incriminating. Maybe its the helm version changes in the dockerfile? I have tried rolling forward and backwards couple of times and it always behaves the same. These are the only logs from the lovely-plugin container.
|
Seeing as I don't really know what is going on, can you see if 1.0.3 does any better for you? |
Just tried 1.0.3 - same issue |
Thanks for trying |
I have done some trials with custom built image and it looks like upgrading helm dependency in the dockerfile to 3.14.1+ is what breaks the functionality.
Helm change log for 3.14.1 just mentions a security fix, looks like they started validating chart names: |
But this is an application, not a Chart.yaml? |
you are right, it is also in the chart name Chart.yaml
|
So, the app-of-apps is a Chart in itself. Can you elaborate on the directory structure of this application, in particular where the Chart.yaml(s) are? |
argocd application (/applications/argocd.yaml) which deploys app of apps (/argocd/yaml/app-of-apps.yaml) definition as part of itself is that a non recommended/supported way? |
I only care about the application structure of the one application that is causing issues. Is that a the last of these, or the app of apps? The structure of the failing application has a Chart.yaml in the root directory with a vault substituted name in it? |
correct, it is the yyy application that is causing the issue (not the app of apps) Chart.yaml
|
So, this worked before Helmet 3.14.1 because the helm template expansion could work because it just didn't care about the name at that stage. It now cares about the name. Template expansion happens before the vault substitution with So, you have a couple of options:
|
Thanks, that seems to work even in 1.0.3. I had to move the definitions from the root folder to ./chart folder for the pre-processor to work, but otherwise all good. definition in the app if anyone ever encounters this:
|
Hi,
I have an app of apps with bunch of argocd applications and couple of them have dynamic names. This worked perfectly fine on 1.0.0, but is now broken on 1.0.1. Maybe the order of name check vs interpolation has changed?
It still displays name of application correctly in the argocd ui even on 1.0.1.
Application definition:
Error in the logs:
Work around:
rollback to 1.0.0
The text was updated successfully, but these errors were encountered: