Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write benchmarks for React Final Form #31

Open
3 tasks
crutchcorn opened this issue Feb 13, 2023 · 2 comments
Open
3 tasks

Write benchmarks for React Final Form #31

crutchcorn opened this issue Feb 13, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@crutchcorn
Copy link
Member

crutchcorn commented Feb 13, 2023

Write benchmarks to show React Final Form usage against HouseForm for performance metrics.

To make it more 1:1, use Zod parseAsync and <Field render={ like this:

     <Field
          name="bio"
          render={({ input, meta }) => (
            <div>
              <label>Bio</label>
              <textarea {...input} />
              {meta.touched && meta.error && <span>{meta.error}</span>}
            </div>
          )}
        />

https://final-form.org/docs/react-final-form/getting-started

https://final-form.org/docs/react-final-form/examples/field-level-validation

https://codesandbox.io/s/wy7z7q5zx5

https://github.com/colinhacks/zod#parseasync

Add the following benchmarks:

https://github.com/crutchcorn/houseform/tree/main/lib/benchmarks

For each of the files:

Then add to this docs file:

https://github.com/crutchcorn/houseform/blob/main/docs/comparison.md

This can be one PR or 4

@crutchcorn crutchcorn added documentation Improvements or additions to documentation good first issue Good for newcomers labels Feb 13, 2023
@chasingtherain
Copy link
Contributor

Hi @crutchcorn

Could you assign this issue to me pls?

Thank you

@chasingtherain
Copy link
Contributor

steps to take:

  • import react final form
  • create a component for react final form
  • add benchmark for react final form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants