Improve adding data to final Result objects #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new step methods `addToResult()` and `addLaterToResult()`. `addToResult()` is a single replacement for `setResultKey()` and `addKeysToResult()` (which are removed) that can be used for array and non array output. `addLaterToResult()` is a new method that does not create a Result object immediately, but instead adds the output of the current step to all the Results that will later be created originating from the current output. New step method `createsResult()`, so you can differentiate if a step creates a Result object, or just keeps data to add to results later (new `addLaterToResult()` method). Primarily relevant for library internal use. `getResultKey()` is also removed with `setResultKey()`. It's removed without replacement, as it doesn't really make sense any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new step methods
addToResult()andaddLaterToResult().addToResult()is a single replacement forsetResultKey()andaddKeysToResult()(which are removed) that can be used for array and non array output.addLaterToResult()is a new method that does not create a Result object immediately, but instead adds the output of the current step to all the Results that will later be created originating from the current output.New step method
createsResult(), so you can differentiate if a step creates a Result object, or just keeps data to add to results later (newaddLaterToResult()method). Primarily relevant for library internal use.getResultKey()is also removed withsetResultKey(). It's removed without replacement, as it doesn't really make sense any longer.