Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same dynamicImportWrapper is used for background and content scripts #15

Closed
jacksteamdev opened this issue Dec 5, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jacksteamdev
Copy link
Contributor

Describe the bug
The module loader emits the same scripts for both background and content scripts. This isn't a big deal, but it might delay content script loading.

To Reproduce
Steps to reproduce the behavior:

  1. Bundle a Chrome extension
  2. Look at the module loader scripts added to background.scripts and content_scripts.
  3. Both scripts wrap wake events

Expected behavior
Content scripts should not do anything with events, since they don't sleep.

Additional context
Relevant code:

https://github.com/bumble-org/rollup-plugin-chrome-extension/blob/0a4499fb049205540e9f4523541487b980786f33/src/manifest-input/index.ts#L331-L347

@jacksteamdev jacksteamdev added the bug Something isn't working label Dec 5, 2019
@jacksteamdev jacksteamdev self-assigned this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant