Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket connection not reconnecting on fail #91

Closed
darnfish opened this issue Nov 21, 2019 · 1 comment · Fixed by #114
Closed

WebSocket connection not reconnecting on fail #91

darnfish opened this issue Nov 21, 2019 · 1 comment · Fixed by #114
Assignees
@AznManDown
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Cryb 1 Roadmap

Comments

@darnfish
Copy link
Contributor

WebSocket connections from @cryb/web to @cryb/api does not reconnect when API restarts or another error occurs for example. This transaction should be handled in store/index.js
@darnfish darnfish added bug Something isn't working good first issue Good for newcomers labels Nov 21, 2019
@darnfish darnfish self-assigned this Nov 21, 2019
@JeDaYoshi JeDaYoshi pinned this issue Feb 27, 2020
@JeDaYoshi JeDaYoshi added this to To do in Cryb 1 Roadmap Mar 3, 2020
@JeDaYoshi JeDaYoshi assigned AznManDown and unassigned darnfish Mar 3, 2020
@AznManDown
Copy link
Contributor

Index.js already has functions for a reconnect. Though there is a possibility that it isn't reconnecting properly / trying to reconnect when it isn't supposed to, according to JeDaYoshi. I'll investigate further and see what I can reproduce.

@AznManDown AznManDown added the needs reproduced Needs to be confirmed if issue can be reproduced easily label Mar 3, 2020
@JeDaYoshi JeDaYoshi moved this from To do to In progress in Cryb 1 Roadmap Mar 3, 2020
@JeDaYoshi JeDaYoshi moved this from In progress to To do in Cryb 1 Roadmap Mar 3, 2020
@JeDaYoshi JeDaYoshi removed the needs reproduced Needs to be confirmed if issue can be reproduced easily label Mar 9, 2020
@JeDaYoshi JeDaYoshi moved this from To do to Done in Cryb 1 Roadmap Mar 9, 2020
@JeDaYoshi JeDaYoshi mentioned this issue May 8, 2020
Merged
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AznManDown AznManDown

Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Cryb 1 Roadmap
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The 2020-03 changes crybapp/web
3 participants
@JeDaYoshi @darnfish @AznManDown