Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement input validation #6

Closed
crybot opened this issue Jun 6, 2021 · 1 comment
Closed

Implement input validation #6

crybot opened this issue Jun 6, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@crybot
Copy link
Owner

crybot commented Jun 6, 2021

As of now, there is no input validation implemented. A possibly incomplete list of validation requirements is as follows:

  • All currently implemented textfields should be validated as non-negative integer inputs and should not be empty

  • The length of the microcycle should not exceed 30 days and should be a multiple of 7 days

  • The number of rest days should not exceed the length of the microcycle

  • The given maximum value of consecutive workouts should no exceed the length of the microcycle

  • The given maximum value of consecutive rest days should no exceed the length of the microcycle

  • Each rotation input should be an integer in the interval [0, 3]

  • Other inputs' constraints are implicitly enforced by the optimization procedure, so there is no need to manually specify them.

Input validation should be performed prior to split generation and its outcome should be communicated to the user somehow

@crybot crybot added the enhancement New feature or request label Jun 6, 2021
@crybot crybot self-assigned this Jun 6, 2021
@crybot
Copy link
Owner Author

crybot commented Jun 7, 2021

Closing after commit 6fd0fcd5ec4aa88c83c94e7b9bea3fd9aff33380

@crybot crybot closed this as completed Jun 7, 2021
@crybot crybot added this to the First release milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant