Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of SLF4J for logging #2

Open
payne911 opened this issue Dec 13, 2020 · 2 comments
Open

Allow usage of SLF4J for logging #2

payne911 opened this issue Dec 13, 2020 · 2 comments
Labels
type: enhancement Make an existing feature better

Comments

@payne911
Copy link

payne911 commented Dec 13, 2020

I'd love to be able to get KryoNet to use any SLF4J implementation.

Some work has already been done in that regards: https://github.com/hpadmanabhan/kryonet-slf4j/commits/master

MinLog is probably better in terms of performance, but it lacks on the feature side.

This is nothing too alarming or concerning, just a simple convenience thing. If it proves to be too much work to implement, you can probably just ignore it.

@crykn crykn added the type: enhancement Make an existing feature better label Dec 13, 2020
@crykn
Copy link
Owner

crykn commented Dec 28, 2020

Hey @payne911, thanks for the idea and especially the link to @hpadmanabhan's repo! I will look into that, when I find some time. As an alternative: I know that I recommended one of the minlog-slf4j replacements to you (jdanbrown/minlog-slf4j or dorkbox/MinLog-SLF4J): were they any good?

(Completely unrelated, but a minlog to Gdx.log replacement would be an interesting idea as well.)

@payne911
Copy link
Author

As an alternative: I know that I recommended one of the minlog-slf4j replacements to you (jdanbrown/minlog-slf4j or dorkbox/MinLog-SLF4J): were they any good?

I had voiced my concerned after setting aside my other project, so I don't think I had tried your suggestions.

And I thought I'd use KryoNet for my upcoming project, but I ended up wanting to try getting a build for html so I went the WebSockets way instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Make an existing feature better
Projects
None yet
Development

No branches or pull requests

2 participants