[Task] CI fails to download cryostat-core dependency

[andrewazores]

For example:

#125
(https://github.com/cryostatio/cryostat-agent/actions/runs/5070291951/jobs/9105123984?pr=125)

The project's pom.xml is configured to search the GitHub Maven Packages repository, but authentication is failing.

cryostat-agent/pom.xml

Line 13 in 8d2eb41

<repositories>

The CI workflow does have a step that is supposed to set up the Maven settings.xml that provides the credentials however:

cryostat-agent/.github/workflows/ci.yaml

Line 32 in 8d2eb41

servers: '[{"id": "github", "username": "dummy", "password": "${env.GITHUB_TOKEN_REF}"}]'

And the same or very similar configuration is used in the main Cryostat repository, which works and is able to download the cryostat-core dependency:

https://github.com/cryostatio/cryostat/blob/2b0cd5adacf8f928f8666f36663b0a5b31e0e76b/.github/workflows/ci-jobs.yml#L53

[ebaron]

This is the pull_request_target issue right?

[andrewazores]

I think so, yes. The secret is probably unreadable to the actions runners with the current configuration so the authentication fails because the password/token being provided in the Maven settings.xml would be an empty string.

[andrewazores]

(it's frustrating that GitHub Packages still doesn't allow unauthenticated downloads)

[andrewazores]

#149 (comment)

[andrewazores]

It looks like the CI job also needs to (re)trigger when PRs are labelled or unlabelled:

#150

This PR is failing because the runner thinks safe-to-test is missing, but it is actually there, and removing/re-adding the label doesn't trigger the job again, nor does it seem to be able to refresh its state on a re-run.

cryostat-agent/.github/workflows/ci.yaml

Line 10 in f0744e9

pull_request_target:

vs

https://github.com/cryostatio/cryostat/blob/main/.github/workflows/pr-ci.yml#L13

[maxcao13]

Sounds good, I'll redo it today.

[maxcao13]

Fixed with #151, hopefully.

[andrewazores]

Looks good:
https://github.com/cryostatio/cryostat-agent/actions/runs/5292782560/jobs/9580084638?pr=150