Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] PR CI should test -core changes in a Cryostat container image against existing itests #221

Closed
andrewazores opened this issue May 25, 2023 · 0 comments · Fixed by #275
Closed

[Task] PR CI should test -core changes in a Cryostat container image against existing itests #221

andrewazores opened this issue May 25, 2023 · 0 comments · Fixed by #275
Assignees
@mwangggg
Labels
ci help wanted Extra attention is needed

Comments

@andrewazores
Copy link
Member

Currently, when a PR is opened, only -core's own unit tests are run.

It would be great if, after that passes, the built -core artifact is then used to build a Cryostat container image, and that container image run through the Cryostat integration tests. This way any changes to -core are automatically tested for regressions in the primary consumer of the -core library.

-agent and -reports also consume -core, so they could also be tested against, but the Cryostat server is the most important one to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwangggg mwangggg

Labels
ci help wanted Extra attention is needed
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
2 participants
@andrewazores @mwangggg