Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] CI fails to download -core #198

Open
andrewazores opened this issue Jan 23, 2024 · 7 comments
Open

[Task] CI fails to download -core #198

andrewazores opened this issue Jan 23, 2024 · 7 comments
Labels
chore Refactor, rename, cleanup, etc. ci

Comments

@andrewazores
Copy link
Member

andrewazores commented Jan 23, 2024

https://github.com/cryostatio/cryostat-reports/actions/runs/7625164851/job/20768861530?pr=197

Error:  Failed to execute goal on project cryostat-reports: Could not resolve dependencies for project io.cryostat:cryostat-reports:jar:2.5.0-SNAPSHOT: Failed to collect dependencies at io.cryostat:cryostat-core:jar:2.27.0: Failed to read artifact descriptor for io.cryostat:cryostat-core:jar:2.27.0: The following artifacts could not be resolved: io.cryostat:cryostat-core:pom:2.27.0 (absent): Could not transfer artifact io.cryostat:cryostat-core:pom:2.27.0 from/to github (https://maven.pkg.github.com/cryostatio/cryostat-core): status code: 401, reason phrase: Unauthorized (401) -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error: Process completed with exit code 1.

Related to #81

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. ci labels Jan 23, 2024
@andrewazores
Copy link
Member Author

Still not working. Not sure what else I have missed. @aali309 @mwangggg any ideas?

@mwangggg
Copy link
Member

mwangggg commented Jan 25, 2024

oh I think if you use actions/cache@v3 to cache instead of actions/setup-java@v3, there won't be these errors anymore

@andrewazores
Copy link
Member Author

I'll give it a shot.

@andrewazores
Copy link
Member Author

@mwangggg
Copy link
Member

I think maybe the core image needs to be built and cached here? There's no way for the CI to obtain the -core jar otherwise and I think that's why it's complaining... this only seems to have started happening after we switched to the default GITHUB_TOKEN

@andrewazores
Copy link
Member Author

It shouldn't need to be built, just downloading it from GH mvn should be enough. I'm not sure why the token suddenly stopped working, it looks like it broke on its own on another Dependabot update PR, so I guess it expired or was revoked? It was recently updated though. I figured I could get around that by just using the same token we use elsewhere, but I guess not.

Anyway, we're in progress with getting -core builds onto Maven Central, so that will clear up all these authentication annoyances. Maybe we just wait for that.

@mwangggg
Copy link
Member

oh do you need to include env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} to that step??=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci
Projects
None yet
Development

No branches or pull requests

2 participants