Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Machine-processable automated analysis results #23

Closed
Tracked by #946
andrewazores opened this issue Apr 6, 2022 · 3 comments · Fixed by #40
Closed
Tracked by #946

[Task] Machine-processable automated analysis results #23

andrewazores opened this issue Apr 6, 2022 · 3 comments · Fixed by #40
Assignees
Labels
dependent feat New feature or request good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

Depends on https://github.com/cryostatio/cryostat/issues/880

When cryostat supports a JSON response format for automated analysis, the reports sidecar must also support the same for deployments where cryostat delegates requests rather than forking a subprocess.

@andrewazores andrewazores added good first issue Good for newcomers feat New feature or request labels Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This PR/issue depends on:

@andrewazores andrewazores changed the title Machine-processable automated analysis results [Task] Machine-processable automated analysis results May 17, 2022
@maxcao13 maxcao13 self-assigned this Jun 8, 2022
@maxcao13
Copy link
Member

As for this issue, does this need a separate endpoint?

getReport at the /report endpoint is supposed to return a String, and since it's internal to cryostat does it make sense to have another endpoint (e.g. at /reportEval) for the Map/JSON RuleEvaluation object that returns the Map instead of the String?

@andrewazores
Copy link
Member Author

Ideally it would still be the same endpoint and use the same Accept/Content-Type headers as previously described. Probably worth doing some reading on the @Produces/@Consumes annotations you see in that implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent feat New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants