Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some KubernetesNodeTypes #659

Closed
ebaron opened this issue Aug 25, 2021 · 0 comments · Fixed by #660
Closed

Remove some KubernetesNodeTypes #659

ebaron opened this issue Aug 25, 2021 · 0 comments · Fixed by #660
Assignees
Projects

Comments

@ebaron
Copy link
Member

ebaron commented Aug 25, 2021

Some node types are unlikely to be in the owner hierarchy of a Pod: Service, Ingress, Route, Namespace. In the interest of keeping the Kubernetes permissions granted to Cryostat minimal, these permissions are not granted when deploying Cryostat with the operator.

If for some reason a user has a Pod owned by one of these unlikely parents, Cryostat will attempt to look up that parent and fail with insufficient permissions. This can lead to no targets being available in the targets dropdown (see exception in cryostatio/cryostat-operator#234). Even though it's unlikely, we should remove these KubernetesNodeTypes to ensure this can't happen.

@ebaron ebaron self-assigned this Aug 25, 2021
@andrewazores andrewazores added this to Backlog in API v2 via automation Aug 25, 2021
API v2 automation moved this from Backlog to Done Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
API v2
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant