Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication support for custom webhooks #13

Closed
cryptaliagy opened this issue Jul 29, 2023 · 0 comments · Fixed by #14
Closed

Add authentication support for custom webhooks #13

cryptaliagy opened this issue Jul 29, 2023 · 0 comments · Fixed by #14
Labels
enhancement New feature or request targets Something related to Pixy targets

Comments

@cryptaliagy
Copy link
Owner

cryptaliagy commented Jul 29, 2023

After closing #11, basic auth & bearer auth can now be more safely implemented, as there is an alternative to explicitly setting this information in the configuration file.

These should be provided under an auth key for the webhook, which should support either option depending on which subkeys are used (username/password for basic auth, bearer for bearer auth).

I think it would also be a good idea to emit a warning if basic auth is used to discourage the use of it.

@cryptaliagy cryptaliagy added enhancement New feature or request targets Something related to Pixy targets labels Jul 29, 2023
@cryptaliagy cryptaliagy linked a pull request Aug 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request targets Something related to Pixy targets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant